Opening non-image attachments is broken

[mejo-]

Describe the bug
Opening non-image attachments is broken in latest Text. I'd expect them to be opened in the Viewer, but instead a modal is displayed that tries to load them as image and displays them as broken image.

Probably related: #2924 @luka-nextcloud

To Reproduce
Steps to reproduce the behavior:

1. Open a Text file, upload a non-image attachment
2. Click on the attachment
3. See the modal showing a broken image

Expected behavior
The attachment should be opened in the viewer.

[mejo-]

After discussing this a bit more I'm not sure anymore whether we want the attachment to be opened in Viewer - because Text itself might already be open in Viewer. 🤔

[mejo-]

text/src/nodes/ImageView.vue

Line 38 in bf6c6bb

@click="handleImageClick(src)">

is the relevant part in code.

[luka-nextcloud]

@mejo- @juliushaertl
I would suggest to show an icon based on the file type of attachments in the preview modal.
Or just a file icon for all non-image file, it may be a simple fix for now.

[mejo-]

I would suggest to show an icon based on the file type of attachments in the preview modal.

I'm not sure whether that's useful from a user perspective. How about opening non-image attachments in the files app in a new tab (target="_blank") instead. That way the files app could take care of opening the attachment in viewer.

Maybe we would just make the whole non-image NodeView a link to the file view (/f/<fileId>) and let the default linkHandler do it's job. That way we could take care of opening it in Viewer from Collectives with its own linkHandler later on 🤔

[luka-nextcloud]

@mejo- Sounds good to me, totally agree with you.

[hcaihao]

Does this issue sloved? How to update & test?