Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attach a pdf file to a markdown file #5030

Closed
mherweg opened this issue Aug 25, 2023 · 3 comments · Fixed by #5042
Closed

attach a pdf file to a markdown file #5030

mherweg opened this issue Aug 25, 2023 · 3 comments · Fixed by #5042
Labels
0. Needs triage bug Something isn't working

Comments

@mherweg
Copy link

mherweg commented Aug 25, 2023

Steps to reproduce

in NC web GUI create a "text"(.md) File
use the attach button to attach a pdf file from server or from Computer
close/save this "text" file
open it again

Expected behaviour

when I click on the the pdf preview, the pdf file will open or offered for download
Actual behaviour

a "broken image" preview - it looks like the pdf is treated like a gif or jpg
Server configuration

I tried it on 3 different NC Servers, run by 3 different teams. all Linux/docker

NC Version: 27.0.2

Operating system:
Debian Linux

@mherweg mherweg added 0. Needs triage bug Something isn't working labels Aug 25, 2023
@GOWTHAM2K1
Copy link

can i work on it

@susnux susnux transferred this issue from nextcloud/viewer Nov 24, 2023
@juliushaertl
Copy link
Member

There is some ongoing work on this done by @mejo- to make metadata of attachments easier accessible in the frontend to prepare for the fix of this, so maybe he could comment if there is anything to pair up with.

@mejo- mejo- mentioned this issue Nov 27, 2023
49 tasks
@mejo- mejo- linked a pull request Nov 27, 2023 that will close this issue
49 tasks
@mejo-
Copy link
Member

mejo- commented Nov 27, 2023

Indeed, #5042 will fix this.

@GOWTHAM2K1 thanks for offering help here. If you like, a review and testing of this PR would be much appreciated!

mejo- added a commit that referenced this issue Nov 27, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Nov 27, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Nov 28, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Nov 29, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
backportbot-nextcloud bot pushed a commit that referenced this issue Nov 29, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 5, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 5, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 5, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Dec 5, 2023
When viewer is available, not in use and supports the mimetype, and
we're not in a public share, open the attachment in viewer. Otherwise,
download the attachment.

Fixes: #3849
Fixes: #4723
Fixes: #5030

Signed-off-by: Jonas <jonas@freesources.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants