Can't scroll through shared addressbook list

[DerSaxxe]

If I get many shared contacts (addressbooks) then in settings it is not possible to scroll them.
Please look at the screenshot

[irgendwie]

@jancborchardt Already told you about that at the meetup! 😊 Would be cool to have a good looking solution for this. Also @skjnldsv

[jancborchardt]

Right! 3 things we need to do:

• restrict the height of the settings area (should be done in core/css/apps.css), for example to 500px or max 80% height.
• put the actions in a 3-dot menu because four icons next to each other are difficult to understand
• ellipsize the names if they are too long so it doesn’t break

cc @nextcloud/designers

[jakobsack]

tasks 1 and 3 are ready to be merged. Great work, @pgys !

[skjnldsv]

for task 2, I can suggest this again:

from owncloud/contacts#518 (comment)

[jancborchardt]

@skjnldsv let’s do it like in the other apps with the popover icons+text. Without the text, 4 icons next to each other are very difficult to understand.

[skjnldsv]

Okay, but without texts. Otherwise, we won't have enough space to display the popup and I don't really want to add a big bottom padding 😉

[jancborchardt]

What do you mean? The icons need the text for sure, like in all the other menus. :) If there’s not enough space to display the popup menu downwards then we have to make room downwards. We can add the padding depending on if you click the menu so it’s not always there. :)

[skjnldsv]

I completely change my view now. I fully agree with you.
I was waiting for my work on the css guidelines. :)
A pr is on its way.

[jancborchardt]

@skjnldsv ❤️ :) high five

[skjnldsv]

@jancborchardt look at other opened pr on contacts pls :)

[skjnldsv]

Anyhow, the popover menu is a bit broken on stable11. Should I backport my apps.css edits?

[jancborchardt]

Are they easily backportable with pure CSS and minimal invasion? Backports are only for really important bugfixes, and if it’s sure that it doesn’t cause more bugs. ;)

[skjnldsv]

Here's the situation I'm at:

• With the recent popover fix on master12, the popover pr on contact works fine
• Since the popover wasn't really well implemented, this is buggy on stable11
• I can add exception in the contacts css, but since we're gonna have one version to rule them all, I don't like duplicate code that won't be used by stable12

So should we backport? Or add css exceptions in contacts, I'm a bit lost 😞

[irgendwie]

@skjnldsv should already be fixed, or not?

[skjnldsv]

I think so yeah, need to test it.

[irgendwie]

#101 is merged, let's close this for now.