Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restricted the height of the settings area in core/css/apps.css #1951

Merged
merged 1 commit into from
Nov 2, 2016

Conversation

pgys
Copy link
Member

@pgys pgys commented Oct 29, 2016

to max 80%

@mention-bot
Copy link

@pgys, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @BernhardPosselt and @PVince81 to be potential reviewers.

@rullzer rullzer added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews labels Oct 29, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Oct 29, 2016
@rullzer
Copy link
Member

rullzer commented Oct 29, 2016

@pgys thanks for your PR!

@nextcloud/designers please have a look!

@schiessle
Copy link
Member

schiessle commented Oct 29, 2016

Thanks for your contribution! Would be great to have a screenshot from before and after your changes. This makes it often easier to get a idea about the improvement.

@pgys
Copy link
Member Author

pgys commented Oct 29, 2016

@rullzer @schiessle thanks for your feedback!
The request refers to nextcloud/contacts#14

@juliusknorr
Copy link
Member

@pgys Awesome, thanks for the contribution. Changes look good 👍

To get this in, you need to sign your commit. Running git commit --amend --signoff and force push to the branch should work fine here.
See https://github.com/nextcloud/server/blob/master/.github/CONTRIBUTING.md#sign-your-work for more details.

…x 80%

Signed-off-by: pgys <info@pexlab.space>
@pgys pgys force-pushed the settingsmaxheight branch from 70c137f to bd7abc2 Compare October 29, 2016 15:51
@rullzer
Copy link
Member

rullzer commented Nov 2, 2016

LGTM

@rullzer rullzer merged commit 19af06c into master Nov 2, 2016
@rullzer rullzer deleted the settingsmaxheight branch November 2, 2016 07:45
@jancborchardt
Copy link
Member

Awesome work @pgys, welcome to the Nextcloud community! :)

@skjnldsv
Copy link
Member

skjnldsv commented Nov 2, 2016

Welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants