Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generating the redirect url #1972

Merged
merged 1 commit into from
Dec 14, 2020
Merged

Fix generating the redirect url #1972

merged 1 commit into from
Dec 14, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 11, 2020

Fix #1852

@juliusknorr juliusknorr added bug Something isn't working 3. to review Waiting for reviews labels Dec 11, 2020
@juliusknorr juliusknorr requested a review from skjnldsv December 11, 2020 14:35
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the bugfix/noid/direct-url branch from 4b0b53b to 6d7fd24 Compare December 11, 2020 15:12
@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #1972 (48c15ff) into master (8d3be14) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1972      +/-   ##
============================================
+ Coverage     67.53%   67.58%   +0.04%     
  Complexity      249      249              
============================================
  Files            22       22              
  Lines           690      691       +1     
============================================
+ Hits            466      467       +1     
  Misses          224      224              
Impacted Files Coverage Δ Complexity Δ
lib/Controller/ContactsController.php 100.00% <100.00%> (ø) 2.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d3be14...6d7fd24. Read the comment docs.

@skjnldsv skjnldsv merged commit b925bf3 into master Dec 14, 2020
@welcome
Copy link

welcome bot commented Dec 14, 2020

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22
Most developers hang out on IRC. So join #nextcloud-contacts and #nextcloud-dev on Freenode for a chat!

@skjnldsv skjnldsv deleted the bugfix/noid/direct-url branch December 14, 2020 15:47
@juliusknorr
Copy link
Member Author

Is #nextcloud-dev still a thing 🤔 ?

@skjnldsv
Copy link
Member

Guess not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(New Global) Search URL broken for contacts app
2 participants