Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose boards as calendars #1545

Merged
merged 15 commits into from
Sep 15, 2020
Merged

Expose boards as calendars #1545

merged 15 commits into from
Sep 15, 2020

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Feb 16, 2020

@raimund-schluessler

This comment has been minimized.

@juliusknorr

This comment has been minimized.

lib/DAV/Calendar.php Outdated Show resolved Hide resolved
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Contributor

@jakobroehrl jakobroehrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working fine :)
But I saw the due hour is +1h in the calendar. A 12:00 due card is in the calendar show as a 13:00 due event

@hitam4450
Copy link

hitam4450 commented Sep 15, 2020

Maybe timezone problem ?
Daylight saving time ?

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Copy link
Member Author

Hm, I didn't have this when testing, but I pushed a commit that should force UTC interpretation for the duedate so that the clients can take care of the timezone. Could you check if that fixes it for you?

@jakobroehrl
Copy link
Contributor

Hm, I didn't have this when testing, but I pushed a commit that should force UTC interpretation for the duedate so that the clients can take care of the timezone. Could you check if that fixes it for you?

Now it's working.

@juliusknorr
Copy link
Member Author

Let's get this in for the next beta 🚀

@juliusknorr juliusknorr merged commit b545639 into master Sep 15, 2020
@juliusknorr juliusknorr deleted the enh/dav-calendars branch September 15, 2020 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants