Let apps handle clicks on todo entries

[juliusknorr]

Description

Open task entries that are exposed by deck inside of the deck app by emitting an event that can be handled by apps

Type of change

• New feature (non-breaking change which adds functionality)

How to test / use your changes?

Requires nextcloud/deck#2683

Checklist:

• My code follows the style guidelines of this project
• I signed off my changes (git commit -sm "Your commit message")
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[codecov]

Codecov Report

Merging #2478 (1bdef9a) into master (75a409d) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master    #2478      +/-   ##
============================================
+ Coverage     29.66%   29.68%   +0.02%     
  Complexity      116      116              
============================================
  Files           153      153              
  Lines          5485     5487       +2     
  Branches        812      812              
============================================
+ Hits           1627     1629       +2     
  Misses         3858     3858              

Flag	Coverage Δ	Complexity Δ
javascript	24.23% <100.00%> (+0.02%)	0.00 <0.00> (ø)
php	94.15% <ø> (ø)	0.00 <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ	Complexity Δ
src/fullcalendar/interaction/eventClick.js	100.00% <100.00%> (ø)	0.00 <0.00> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a409d...2112efe. Read the comment docs.

[raimund-schluessler]

I have a problem understanding how that would work. When you are in the Calendar app, the Deck app isn't loaded, no? How could the Deck app then react to a click on a todo (via the event-bus)?

[juliusknorr]

I have a problem understanding how that would work. When you are in the Calendar app, the Deck app isn't loaded, no? How could the Deck app then react to a click on a todo (via the event-bus)?

See https://github.com/nextcloud/deck/pull/2683/files for the deck implementation. We basically register a small helper script that gets loaded and handles the event.

[tcitworld]

Instead of asking admins to install the tasks app, maybe we could fallback to link to the task in the calendar app?

[juliusknorr]

Instead of asking admins to install the tasks app, maybe we could fallback to link to the task in the calendar app?

Would be fine by me, but I'd say that would be separate from that PR.