Fix search pagination cursor #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
julien-nc
requested review from
nickvergessen,
juliusknorr and
luka-nextcloud
nickvergessen
approved these changes
Sep 30, 2021
juliusknorr
approved these changes
Oct 4, 2021
|
/backport to stable22 |
|
/backport to stable1.4 |
|
/backport to stable1.2 |
|
The backport to stable22 failed. Please do this backport manually. |
|
The backport to stable1.4 failed. Please do this backport manually. |
|
The backport to stable1.2 failed. Please do this backport manually. |
|
Ah let me revert that in favor of #3344 actually and do the backports there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we get both boards and cards when searching and the number of cards is higher than the limit, the wrong index is used to get the pagination cursor.
This avoids the crash but the search is still not completely ok because we get the same boards in each page. Board search does not use the cursor.