Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable23] Transfer ownership #3664

Merged
merged 33 commits into from
Apr 11, 2022
Merged

[stable23] Transfer ownership #3664

merged 33 commits into from
Apr 11, 2022

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 22, 2022 •
edited
Loading

Backport of #2496

  • Drop PHP 7.2 from CI/Composer as it is not supported on 23 server
  • Adjust cases where the query builder is used on master but not stable23
  • Manual test of occ and UI

@juliusknorr juliusknorr changed the base branch from master to stable23 March 22, 2022 13:13
matchish and others added 18 commits March 22, 2022 14:14
@matchish @juliusknorr
Add deck:transfer-ownership command
eb8a321 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish @juliusknorr
Update docs
fc9fa5d 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>

fix: conflicts
@matchish @juliusknorr
Add tests
53d462b 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish @juliusknorr
Fix code style
d526978 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish @juliusknorr
Fix wrong class name
ce85b43 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish @juliusknorr
Check type before transfer card participants ownership
36a9d2e 
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>

temp
@matchish @juliusknorr
Transfer deck ownership even if target user already participant of a …
e70e712 
…board

#1955 (comment)
Signed-off-by: Sergey Shliakhov <husband.sergey@gmail.com>
@matchish @juliusknorr
Fix coding styles
1641373 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Max <max@nextcloud.com>
@juliusknorr
Fix card mapper query for transfer
da745f9 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Use proper description of what gets transferred
7c68414 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Just cleanup old ACL rules, there are none for the board owner so not…
c0886cf 
…hing to cleanup or persist there

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Make queries work with the new base mapper
a8c2248 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

fix: conflicts
@max-nextcloud @juliusknorr
fix: Assignment is the new AssignedUsers
05dbf67 
Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud @juliusknorr
fix: queries with the new base mapper in BoardMapper
b01d472 
Signed-off-by: Max <max@nextcloud.com>
@luka-nextcloud @juliusknorr
fix: unit test & psalm static code analysis issues
b7f3c2d 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud @juliusknorr
fix: integration tests
981fc8e 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud @juliusknorr
feat: add integration test for transferring board ownership with data
c95c96f 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr
fix: unit tests
26c76fb 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/stable23/2496 branch from 9610698 to ef45df9 Compare March 22, 2022 13:16
juliusknorr and others added 10 commits March 22, 2022 14:22
@juliusknorr
fix: Psalm
48ec973 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Allow transfer of single boards
525a14c 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
cleanup test cases
7f3a318 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: Properly handle limited scope for remapping users
7786c86 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Reuse single board transfer for all user boards
3d925fb 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
fix: test cases using generator
b75fb76 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@luka-nextcloud @juliusknorr
feat: add api endpoint and UI to transfer a board to a different user
f46c31f 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@luka-nextcloud @juliusknorr
fix: feedback
eb69512 
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr
Cover case where the owner is preserved
379f114 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Handle board exceptions more gracefully
a3336cb 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Adjust documentaion wording
cffcd4f 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/stable23/2496 branch from ef45df9 to cffcd4f Compare March 22, 2022 13:22
@juliusknorr
PHP 7.2 compatbility
f840bbb 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
Fix tests and move to 7.3 as a min php version
490cfb2 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr
lint: fix eslint
4dabc22 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the backport/stable23/2496 branch from 30f1c98 to 4dabc22 Compare March 22, 2022 15:03
@juliusknorr juliusknorr requested review from max-nextcloud, luka-nextcloud and julien-nc and removed request for max-nextcloud April 4, 2022 11:40
@luka-nextcloud
Copy link
Contributor

Looks good to me! 👍

@juliusknorr
Remove unused argument
39784dc 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr mentioned this pull request Apr 11, 2022
Merged
@juliusknorr juliusknorr merged commit 541eeb0 into stable23 Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/stable23/2496 branch April 11, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luka-nextcloud luka-nextcloud luka-nextcloud approved these changes

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

@julien-nc julien-nc Awaiting requested review from julien-nc

Assignees
No one assigned
Labels
4. to release enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juliusknorr @luka-nextcloud @matchish @max-nextcloud