Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable23] Transfer ownership #3664

Merged
merged 33 commits into from
Apr 11, 2022
Merged

[stable23] Transfer ownership #3664

Show file tree
Hide file tree
Changes from 32 commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
eb8a321
Add deck:transfer-ownership command
matchish May 21, 2020
fc9fa5d
Update docs
matchish May 25, 2020
53d462b
Add tests
matchish Jun 7, 2020
d526978
Fix code style
matchish Jun 7, 2020
ce85b43
Fix wrong class name
matchish Jun 8, 2020
36a9d2e
Check type before transfer card participants ownership
matchish Jun 9, 2020
e70e712
Transfer deck ownership even if target user already participant of a …
matchish Jul 18, 2020
1641373
Fix coding styles
matchish Jul 18, 2020
da745f9
Fix card mapper query for transfer
juliusknorr Nov 3, 2020
7c68414
Use proper description of what gets transferred
juliusknorr Nov 10, 2020
c0886cf
Just cleanup old ACL rules, there are none for the board owner so not…
juliusknorr Nov 10, 2020
a8c2248
Make queries work with the new base mapper
juliusknorr Nov 10, 2020
05dbf67
fix: Assignment is the new AssignedUsers
max-nextcloud Feb 9, 2022
b01d472
fix: queries with the new base mapper in BoardMapper
max-nextcloud Feb 9, 2022
b7f3c2d
fix: unit test & psalm static code analysis issues
luka-nextcloud Mar 4, 2022
981fc8e
fix: integration tests
luka-nextcloud Mar 8, 2022
c95c96f
feat: add integration test for transferring board ownership with data
luka-nextcloud Mar 10, 2022
26c76fb
fix: unit tests
juliusknorr Mar 14, 2022
48ec973
fix: Psalm
juliusknorr Mar 14, 2022
525a14c
Allow transfer of single boards
juliusknorr Mar 14, 2022
7f3a318
cleanup test cases
juliusknorr Mar 14, 2022
7786c86
fix: Properly handle limited scope for remapping users
juliusknorr Mar 14, 2022
3d925fb
Reuse single board transfer for all user boards
juliusknorr Mar 14, 2022
b75fb76
fix: test cases using generator
juliusknorr Mar 14, 2022
f46c31f
feat: add api endpoint and UI to transfer a board to a different user
luka-nextcloud Mar 14, 2022
eb69512
fix: feedback
luka-nextcloud Mar 16, 2022
379f114
Cover case where the owner is preserved
juliusknorr Mar 21, 2022
a3336cb
Handle board exceptions more gracefully
juliusknorr Mar 22, 2022
cffcd4f
Adjust documentaion wording
juliusknorr Mar 22, 2022
f840bbb
PHP 7.2 compatbility
juliusknorr Mar 22, 2022
490cfb2
Fix tests and move to 7.3 as a min php version
juliusknorr Mar 22, 2022
4dabc22
lint: fix eslint
juliusknorr Mar 22, 2022
39784dc
Remove unused argument
juliusknorr Apr 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

strategy:
matrix:
php-versions: ['7.2', '7.3', '7.4']
php-versions: ['7.3', '7.4']

name: php${{ matrix.php-versions }} lint
steps:
Expand Down
3 changes: 1 addition & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,8 +50,7 @@ ifeq (, $(shell which phpunit 2> /dev/null))
php $(build_tools_directory)/phpunit.phar -c tests/phpunit.xml --coverage-clover build/php-unit.coverage.xml
php $(build_tools_directory)/phpunit.phar -c tests/phpunit.integration.xml --coverage-clover build/php-integration.coverage.xml
else
phpunit -c tests/phpunit.xml --coverage-clover build/php-unit.coverage.xml
phpunit -c tests/phpunit.integration.xml --coverage-clover build/php-integration.coverage.xml
phpunit -c tests/phpunit.integration.xml --testsuite=integration-database --coverage-clover build/php-integration.coverage.xml
endif

test-integration:
Expand Down
1 change: 1 addition & 0 deletions appinfo/info.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
</background-jobs>
<commands>
<command>OCA\Deck\Command\UserExport</command>
<command>OCA\Deck\Command\TransferOwnership</command>
</commands>
<activity>
<settings>
Expand Down
1 change: 1 addition & 0 deletions appinfo/routes.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
['name' => 'board#updateAcl', 'url' => '/boards/{boardId}/acl/{aclId}', 'verb' => 'PUT'],
['name' => 'board#deleteAcl', 'url' => '/boards/{boardId}/acl/{aclId}', 'verb' => 'DELETE'],
['name' => 'board#clone', 'url' => '/boards/{boardId}/clone', 'verb' => 'POST'],
['name' => 'board#transferOwner', 'url' => '/boards/{boardId}/transferOwner', 'verb' => 'PUT'],

// stacks
['name' => 'stack#index', 'url' => '/stacks/{boardId}', 'verb' => 'GET'],
Expand Down
7 changes: 5 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,17 @@
},
"require-dev": {
"roave/security-advisories": "dev-master",
"christophwurst/nextcloud": "^21@dev",
"phpunit/phpunit": "^9",
"christophwurst/nextcloud": "^22@dev",
"phpunit/phpunit": "^8",
"nextcloud/coding-standard": "^0.5.0",
"symfony/event-dispatcher": "^4.0",
"vimeo/psalm": "^4.3",
"php-parallel-lint/php-parallel-lint": "^1.2"
},
"config": {
"platform": {
"php": "7.3"
},
"optimize-autoloader": true,
"classmap-authoritative": true
},
Expand Down
Loading