WIP: Add to the file manager extension the option to edit a file. #1442

camilasan · 2019-09-25T17:34:07Z

The file can be edited in the browser via one of our apps Text,
Collabora or OnlyOffice.

TODO:

create the request with the file id and token to be able to open the file in edit more in the browser
Answer: https://github.com/nextcloud/richdocuments/blob/master/docs/mobile_flow.md
"Basically it is checking if is supported and if it is. A simple post with the file id gets you the URL to open then there are some messages to handle etc. But I must admit I don't know them all by heart. But @tobiasKaminsky does"
"This would also work with OnlyOffice and Text and others? Both require server work, as OnlyOffice currently does not allow to edit files directly. But Julius and me discussed this with OO guys at Conf. For Text Julius is already working on it. It is planned, that this is somehow abstracted in a more generic way, but this is up to Julius."

Also see nextcloud-gmbh/server#14.

jancborchardt · 2019-10-27T18:49:05Z

Copying over the specs from the issue:

This can replace the "Open in browser" entry as it’s basically the same thing but better
"Open in browser" should be called "Open online", just minor wording
The entry should be called "Edit collaboratively"
For odt/ods/odp documents, we need to check on the server if Collabora Online is installed.
For txt/md we need to check for Nextcloud Text on the server

For the last 2 points cc @juliushaertl?

Similarly we could do that for the activity stream in the improved tray menu #877: If a synced file is txt/md/odt/etc the action button could say "Edit" (better wording welcome, but we are short on space).

(The mockup has a unified menu for right-click, that’s a separate discussion though so feel free to ignore that. ;)

juliushaertl · 2019-10-28T07:24:36Z

The related server API PR for 18 is here: nextcloud/server#17625

The entry should be called "Edit collaboratively"

@jancborchardt We probably should use the exposed apps name that is used for editing (e.g. Edit with Collabora Online) since there might be multiple apps you could open a file with.

jancborchardt · 2019-10-29T11:05:26Z

@jancborchardt We probably should use the exposed apps name that is used for editing (e.g. Edit with Collabora Online) since there might be multiple apps you could open a file with.

I wouldn’t expose the app name as this is not really relevant to regular people, it’s more confusing. :) It’s focused on Collabora Online, OnlyOffice and Text, and if there are multiple apps to edit with it should just pick 1 for simplicity.

juliushaertl · 2019-11-04T08:46:28Z

Then we could just use "Edit collaboratively" if only one editor is available, and show the names otherwise I'd say.

The file can be edited in the browser via one of our apps Text, Collabora or OnlyOffice. Signed-off-by: Camila San <hello@camila.codes>

jancborchardt · 2019-12-10T05:59:06Z

src/gui/socketapi.cpp

+        QMimeDatabase db;
+        QMimeType type = db.mimeTypeForFile(fileData.localPath);
+        if (capabilities.hasRichDocuments() && capabilities.supportedRichDocumentsMimetypes().contains(type.name().toLatin1())){
+            listener->sendMessage(QLatin1String("MENU_ITEM:EDIT") + flagString + tr("Edit via ") + capabilities.richDocumentsProductName());


Just to clear this up, we only want it to say "Edit", right? No product name, no "… collaboratively". Can you confirm @karlitschek?

cc @camilasan fyi

(Also, "Edit" should be the first in the list, before the Sharing entries – because you can also do that when the document is not shared.)

@jancborchardt Yes. I would only say 'Edit'. The app that is used depends on the mime type and is not really important for the user.

@karlitschek thanks, agreed!

Suggested change

listener->sendMessage(QLatin1String("MENU_ITEM:EDIT") + flagString + tr("Edit via ") + capabilities.richDocumentsProductName());

listener->sendMessage(QLatin1String("MENU_ITEM:EDIT") + flagString + tr("Edit"));

While implementing this feature with OO, we found a small "problem": you can open also pdf files, which are not editable.
So we thought about "open (remotely)" instead of "edit" as this is more generic.

@tobiasKaminsky can’t we just exclude PDF from it instead? Then the entry will simply say "Open in browser" as specified at #1442 (comment)

That’s much better than complicating the wording for the regular case.

jancborchardt · 2020-02-26T15:36:46Z

So this can be closed as it’s superseded by #1735, right? :) @misch7 @camilasan

jancborchardt · 2020-03-24T10:16:39Z

This was fixed by #1735, closing this hence. :)

camilasan added 1. to develop 4. to test labels Sep 25, 2019

camilasan added this to the 2.7 🌟 UI improvements milestone Sep 25, 2019

camilasan requested a review from misch7 September 25, 2019 17:36

camilasan self-assigned this Sep 26, 2019

camilasan added the server Server related issues. label Sep 26, 2019

camilasan modified the milestones: 2.7 🌟 UI improvements, 2.6.1 🐛 Bug fixes and minor improvements Sep 30, 2019

camilasan modified the milestones: 2.6.1 🐛 Bug fixes and minor improvements, 2.7 🌟 UI improvements Oct 17, 2019

jancborchardt mentioned this pull request Oct 27, 2019

"Edit collaboratively" from the desktop client, in file manager and tray menu #1564

Closed

jancborchardt added the high label Oct 27, 2019

jancborchardt added the design label Oct 27, 2019

This comment has been minimized.

Sign in to view

jancborchardt mentioned this pull request Dec 3, 2019

Feature/add edit button #1566

Closed

Add to the file manager extension the option to edit a file.

17cda22

The file can be edited in the browser via one of our apps Text, Collabora or OnlyOffice. Signed-off-by: Camila San <hello@camila.codes>

camilasan force-pushed the feature/context-menu-edit branch from fcd1a3f to 17cda22 Compare December 9, 2019 16:17

jancborchardt reviewed Dec 10, 2019

View reviewed changes

misch7 mentioned this pull request Jan 18, 2020

Add direct editing to the file manager extension #1735

Merged

jancborchardt closed this Mar 24, 2020

jancborchardt deleted the feature/context-menu-edit branch March 24, 2020 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Add to the file manager extension the option to edit a file. #1442

WIP: Add to the file manager extension the option to edit a file. #1442

camilasan commented Sep 25, 2019 •

edited

Loading

jancborchardt commented Oct 27, 2019

juliushaertl commented Oct 28, 2019 •

edited

Loading

jancborchardt commented Oct 29, 2019 •

edited

Loading

This comment has been minimized.

juliushaertl commented Nov 4, 2019

jancborchardt Dec 10, 2019 •

edited

Loading

jancborchardt Dec 10, 2019

karlitschek Dec 10, 2019

jancborchardt Dec 10, 2019 •

edited

Loading

tobiasKaminsky Dec 10, 2019

jancborchardt Dec 10, 2019

jancborchardt commented Feb 26, 2020

jancborchardt commented Mar 24, 2020

	listener->sendMessage(QLatin1String("MENU_ITEM:EDIT") + flagString + tr("Edit via ") + capabilities.richDocumentsProductName());
	listener->sendMessage(QLatin1String("MENU_ITEM:EDIT") + flagString + tr("Edit"));

WIP: Add to the file manager extension the option to edit a file. #1442

WIP: Add to the file manager extension the option to edit a file. #1442

Conversation

camilasan commented Sep 25, 2019 • edited Loading

jancborchardt commented Oct 27, 2019

juliushaertl commented Oct 28, 2019 • edited Loading

jancborchardt commented Oct 29, 2019 • edited Loading

This comment has been minimized.

juliushaertl commented Nov 4, 2019

jancborchardt Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

jancborchardt Dec 10, 2019

Choose a reason for hiding this comment

karlitschek Dec 10, 2019

Choose a reason for hiding this comment

jancborchardt Dec 10, 2019 • edited Loading

Choose a reason for hiding this comment

tobiasKaminsky Dec 10, 2019

Choose a reason for hiding this comment

jancborchardt Dec 10, 2019

Choose a reason for hiding this comment

jancborchardt commented Feb 26, 2020

jancborchardt commented Mar 24, 2020

camilasan commented Sep 25, 2019 •

edited

Loading

juliushaertl commented Oct 28, 2019 •

edited

Loading

jancborchardt commented Oct 29, 2019 •

edited

Loading

jancborchardt Dec 10, 2019 •

edited

Loading

jancborchardt Dec 10, 2019 •

edited

Loading