Add direct editing to the file manager extension #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Schuster <michael@schuster.ms>
- Fetch in ConnectionValidator::slotCapabilitiesRecieved - Add editors to a list made of the new DirectEditor class TODO: - Add support for re-fetch and continously check for changes (ETag) Signed-off-by: Michael Schuster <michael@schuster.ms>
- Allow direct editing "Edit" when an editor is available for the mime type - Show "Open in browser" if editing is unavailable (as previously) (now on top of the menu list) - Rename the menu title to the app name, "Nextcloud" instead of "Share via ..." Signed-off-by: Michael Schuster <michael@schuster.ms>
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Share context menu: Use
directEditingcapability inSocketApiAdd support for the
directEditingcapabilityConnectionValidator::slotCapabilitiesRecievedDirectEditorclassTODO:
Further improvements:
JsonApiJob: Add methodusePOSTto allow anonymousPOSTrequestsThanks to @tobiasKaminsky and @juliushaertl for guidance! ❤️
And to @camilasan for the super helpful PR #1442 🚀