Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reply button size should be same as the input field, smaller + text color #4577

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Reply button size should be same as the input field, smaller + text color #4577

merged 2 commits into from
Jun 28, 2022

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented May 19, 2022 •
edited
Loading

It should address the third and fourth item in #4435.

textfield

Text color:
text

@camilasan camilasan changed the title Enh/talkreply Reply from desktop menu: Reply button size should be same as the input field, smaller May 19, 2022
@jancborchardt
Copy link
Member

@camilasan haha at the text :D

  • Can you show an animation of how it look when the button is pressed?
  • The typed text should be the full dark text color, looks a bit grey and inactive now, like a placeholder?

@camilasan
Copy link
Member Author

camilasan commented May 19, 2022 •
edited
Loading

Done. See new screenshot.

@camilasan
Copy link
Member Author

camilasan commented May 19, 2022 •
edited
Loading

@jancborchardt If there is anything else, please add to #4435? I will do it next.

@camilasan camilasan changed the title Reply from desktop menu: Reply button size should be same as the input field, smaller Reply button size should be same as the input field, smaller + text color May 19, 2022
claucambra
claucambra requested changes May 20, 2022
View reviewed changes
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

src/gui/tray/TalkReplyTextField.qml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 23, 2022 •
edited
Loading

Codecov Report

Merging #4577 (4e59886) into master (5657fc4) will increase coverage by 0.08%.
The diff coverage is n/a.

❗ Current head 4e59886 differs from pull request most recent head fae5b55. Consider uploading reports for the commit fae5b55 to get more accurate results

@@            Coverage Diff             @@
##           master    #4577      +/-   ##
==========================================
+ Coverage   56.42%   56.51%   +0.08%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
+ Hits         9633     9648      +15     
+ Misses       7438     7423      -15
Impacted Files Coverage Δ
src/libsync/propagatedownload.cpp 64.00% <0.00%> (-1.34%) ⬇️
src/libsync/syncengine.cpp 85.74% <0.00%> (+0.54%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 77.34% <0.00%> (+1.92%) ⬆️
src/libsync/vfs/cfapi/vfs_cfapi.cpp 86.46% <0.00%> (+2.62%) ⬆️
src/libsync/vfs/cfapi/hydrationjob.cpp 56.45% <0.00%> (+3.76%) ⬆️

@camilasan
Copy link
Member Author

/backport to stable-3.5

@mgallien mgallien requested review from claucambra and mgallien June 24, 2022 09:48
Camila added 2 commits June 28, 2022 09:25
@mgallien
Talk reply field should now have the same height as the 'Reply' button.
3ff781e 
Signed-off-by: Camila <hello@camila.codes>
@mgallien
Clean up code, move values to Style.qml.
fae5b55 
Signed-off-by: Camila <hello@camila.codes>
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4577-fae5b5573c3ee1c11c6b9a6ab29e271ef19129e2-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jun 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@camilasan camilasan merged commit f914df9 into master Jun 28, 2022
@camilasan camilasan deleted the enh/talkreply branch June 28, 2022 17:56
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jun 28, 2022
Merged
@mgallien mgallien added this to the 3.6.0 milestone Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra claucambra approved these changes

@mgallien mgallien mgallien approved these changes

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@allexzander allexzander Awaiting requested review from allexzander

@nimishavijay nimishavijay Awaiting requested review from nimishavijay

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@camilasan @jancborchardt @nextcloud-desktop-bot @mgallien @claucambra