Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect skipAutoUpdateCheck in nextcloud.cfg with Sparkle on macOS #4717

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

claucambra
Copy link
Collaborator

Fixes #4711

Signed-off-by: Claudio Cambra claudio.cambra@gmail.com

@claucambra claucambra self-assigned this Jul 11, 2022
@codecov
Copy link

codecov bot commented Jul 11, 2022

Codecov Report

Merging #4717 (f2dbcea) into master (f4744eb) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4717      +/-   ##
==========================================
- Coverage   56.42%   56.40%   -0.02%     
==========================================
  Files         138      138              
  Lines       17070    17070              
==========================================
- Hits         9632     9629       -3     
- Misses       7438     7441       +3     
Impacted Files Coverage Δ
src/libsync/discovery.cpp 84.56% <0.00%> (-0.30%) ⬇️

@camilasan
Copy link
Member

/backport to stable-3.5

@claucambra claucambra force-pushed the bugfix/sparkle-skipautoupdatecheck branch from 1a9c0dc to 64d9a8e Compare July 13, 2022 09:20
Signed-off-by: Claudio Cambra <claudio.cambra@gmail.com>
@claucambra claucambra force-pushed the bugfix/sparkle-skipautoupdatecheck branch from 64d9a8e to f2dbcea Compare July 15, 2022 13:49
@nextcloud-desktop-bot
Copy link

AppImage file: Nextcloud-PR-4717-f2dbceaee04951529c66515f238538832c246dcd-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@claucambra claucambra merged commit 7f40e7e into master Jul 15, 2022
@claucambra claucambra deleted the bugfix/sparkle-skipautoupdatecheck branch July 15, 2022 14:20
@mgallien mgallien added this to the 3.6.0 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: skipUpdateCheck=true doesn't skip update check on macOS
4 participants