Always discover blacklisted folders to avoid data loss when modifying selectivesync list.

[allexzander]

No description provided.

[codecov]

Codecov Report

Merging #5459 (b34d248) into master (73ae8a1) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head b34d248 differs from pull request most recent head 5574ddb. Consider uploading reports for the commit 5574ddb to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5459      +/-   ##
==========================================
- Coverage   57.83%   57.83%   -0.01%     
==========================================
  Files         141      141              
  Lines       18147    18148       +1     
==========================================
  Hits        10495    10495              
- Misses       7652     7653       +1     

Impacted Files	Coverage Δ
src/libsync/discovery.cpp	85.95% <100.00%> (-0.07%)	⬇️
src/libsync/propagateremotemkdir.h	50.00% <0.00%> (-25.00%)	⬇️
src/libsync/progressdispatcher.h	37.50% <0.00%> (-6.95%)	⬇️
src/libsync/owncloudpropagator.h	65.87% <0.00%> (+0.79%)	⬆️

[claucambra]

@allexzander would this be a fix for #1238 ?

[allexzander]

@allexzander would this be a fix for #1238 ?

hmm, it might, but not 100% sure, were you able to reproduce it? in my case I have a bit more complex repro-steps:

• one must check/uncheck other folders that were synced while having completely unsynced local folders to make the issue happen

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-5459-68c7294d5307e5ecacf61d0bbb4986764ccd6ef0-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

[sonarcloud]

Please retry analysis of this Pull-Request directly on SonarCloud.

[allexzander]

/backport to stable-3.7