Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable-3.7] Always discover blacklisted folders to avoid data loss when modifying selectivesync list. #5481

Merged
merged 1 commit into from
Feb 28, 2023
Merged

[stable-3.7] Always discover blacklisted folders to avoid data loss when modifying selectivesync list. #5481

merged 1 commit into from
Feb 28, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #5459

@allexzander @backportbot-nextcloud
Always discover blacklisted folders locally, to avoid data loss of no…
b1186e2 
…n-uploaded files when modifying selectivesync list.

Signed-off-by: alex-z <blackslayer4@gmail.com>
@backportbot-nextcloud backportbot-nextcloud bot added this to the 3.7.4 milestone Feb 28, 2023
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-5481-b1186e2e5465133371db8144ade8e38175a19a03-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 28, 2023

Codecov Report

Merging #5481 (b1186e2) into stable-3.7 (756c86f) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@              Coverage Diff               @@
##           stable-3.7    #5481      +/-   ##
==============================================
- Coverage       57.83%   57.83%   -0.01%     
==============================================
  Files             141      141              
  Lines           18146    18148       +2     
==============================================
+ Hits            10494    10495       +1     
- Misses           7652     7653       +1
Impacted Files Coverage Δ
src/libsync/discovery.cpp 85.95% <100.00%> (+0.02%) ⬆️
src/libsync/vfs/cfapi/cfapiwrapper.cpp 72.95% <0.00%> (-0.23%) ⬇️

@allexzander allexzander merged commit ebfaefb into stable-3.7 Feb 28, 2023
@allexzander allexzander deleted the backport/5459/stable-3.7 branch February 28, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allexzander allexzander allexzander approved these changes

@claucambra claucambra Awaiting requested review from claucambra

@mgallien mgallien Awaiting requested review from mgallien

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.7.4
Development

Successfully merging this pull request may close these issues.
2 participants
@nextcloud-desktop-bot @allexzander