Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support setting NEXTCLOUD_AUTH_TOKEN #1656

Closed
wants to merge 1 commit into from

Conversation

mrueg
Copy link
Contributor

@mrueg mrueg commented Dec 8, 2021

Allows to set up the nextcloud auth token during install.

Purpose is to make the install smoother by exposing it and have server
info and metrics available to verify the status of the install.

As this is only supported in v22 and later, for now a version check is
included.

See also:
nextcloud/serverinfo#269

@mrueg
Copy link
Contributor Author

mrueg commented Dec 10, 2021

@J0WI can you take a look? I saw you were interested in this feature as well. :)

@J0WI
Copy link
Contributor

J0WI commented Dec 10, 2021

I'd prefer #1260

@mrueg
Copy link
Contributor Author

mrueg commented Dec 10, 2021

I agree that there might be additional need for custom scripts, I still feel like exposing a single environment variable like this would help ensuring that it is easy and standardized to work with in helm and other systems.

@mrueg mrueg force-pushed the add-auth-token branch 3 times, most recently from 6226533 to b63993e Compare January 17, 2022 00:51
@mrueg
Copy link
Contributor Author

mrueg commented Mar 25, 2022

I've removed the version check since 21 is now gone.

@mrueg
Copy link
Contributor Author

mrueg commented Mar 29, 2022

@J0WI since #1260 seems to be stale, any chance to get this merged?

Allows to set up the nextcloud auth token during install.

Purpose is to make the install smoother by exposing it and have server
info and metrics available to verify the status of the install.

Signed-off-by: Manuel Rüger <manuel@rueg.eu>
@J0WI
Copy link
Contributor

J0WI commented Apr 28, 2022

A workaround has been posted in #1683 (comment)

IMHO providing a hook would still be more valuable than adding ENV support for any setting or feature.

@J0WI
Copy link
Contributor

J0WI commented Jun 22, 2023

Closing in favour of #1964.

@J0WI J0WI closed this Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants