-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow API endpoint access with a predefined token #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PVince81
commented
Jan 19, 2021
PVince81
force-pushed
the
enh/100/api-with-token
branch
2 times, most recently
from
January 19, 2021 17:35
d98386b
to
51477cf
Compare
PVince81
force-pushed
the
enh/100/api-with-token
branch
from
February 26, 2021 10:00
51477cf
to
68ebff2
Compare
rebased for CI. if this minimal approach is acceptable and secure enough I can then move forward to write tests for this thoughts ? @LukasReschke @nickvergessen @kesselb |
LukasReschke
reviewed
Mar 1, 2021
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
enh/100/api-with-token
branch
from
March 1, 2021 20:06
68ebff2
to
b855a20
Compare
I've added unit tests |
PVince81
requested review from
MorrisJobke,
ChristophWurst,
rullzer,
icewind1991 and
kesselb
March 26, 2021 08:53
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I fixed the info text (which said OC-Token
instead of NC-Token
). But then it works fine 👍
Closed
conrad784
added a commit
to conrad784/collectd-plugins-python
that referenced
this pull request
Jun 4, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick and dirty approach for accessing the metrics endpoint without admin credentials, not that user friendly but works.
Fixes #100
Drawbacks:
Issues: