fix: prevent null token #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
reviewed
Aug 1, 2024
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/null-token
branch
from
aa570c8
to
80169af
Compare
AndyScherzinger
approved these changes
Aug 2, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
|
/backport to stable29 |
|
/backport to stable28 |
2 tasks
|
Third time's the charm 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no clue how that can happen, because we clearly have the token in the URL, but 🤷
{ "reqId": "geRGVLc8I4Nvg8yDzXL6", "level": 3, "time": "2024-07-22T09:10:34+00:00", "remoteAddr": "<IP>", "user": "--", "app": "index", "method": "GET", "url": "/s/<share_token>/download?path=OBFUSCATED.pdf.pdf", "message": "OCA\\Files_DownloadLimit\\Db\\LimitMapper::get(): Argument #1 ($token) must be of type string, null given, called in /var/www/html/apps/files_downloadlimit/lib/Listener/ShareLinkAccessedListener.php on line 59 in file '/var/www/html/apps/files_downloadlimit/lib/Db/LimitMapper.php' line 37", "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:128.0) Gecko/20100101 Firefox/128.0", "version": "29.0.3.4", "exception": { "Exception": "Exception", "Message": "OCA\\Files_DownloadLimit\\Db\\LimitMapper::get(): Argument #1 ($token) must be of type string, null given, called in /var/www/html/apps/files_downloadlimit/lib/Listener/ShareLinkAccessedListener.php on line 59 in file '/var/www/html/apps/files_downloadlimit/lib/Db/LimitMapper.php' line 37", "Code": 0, "Trace": [ { "file": "/var/www/html/lib/private/AppFramework/App.php", "line": 184, "function": "dispatch", "class": "OC\\AppFramework\\Http\\Dispatcher", "type": "->", "args": [ [ "OCA\\Files_Sharing\\Controller\\ShareController" ], "downloadShare" ] },