Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent null token #328

Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix: prevent null token #328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion lib/Listener/ShareLinkAccessedListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,15 @@
use OCP\EventDispatcher\IEventListener;
use OCP\IConfig;
use OCP\Share\IManager;
use Psr\Log\LoggerInterface;

/** @template-implements IEventListener<ShareLinkAccessedEvent> */
class ShareLinkAccessedListener implements IEventListener {
public function __construct(
private IConfig $config,
private IManager $manager,
private LimitMapper $mapper,
private LoggerInterface $logger
) {
}

Expand All @@ -53,8 +55,12 @@ public function handle(Event $event): void {
return;
}

// Make sure we have a valid limit
$token = $event->getShare()->getToken();
if ($token === null) {
return;
}

// Make sure we have a valid limit
try {
$shareLimit = $this->mapper->get($token);
$limit = $shareLimit->getLimit();
Expand All @@ -76,6 +82,8 @@ public function handle(Event $event): void {
$this->mapper->update($shareLimit);
} catch (DoesNotExistException $e) {
// No limit is set, ignore
} catch (\Exception $e) {
$this->logger->error('Error while handling share link accessed event: ' . $e->getMessage());
}
}
}
Loading