[stable24] Fix footer not hidden when Talk sidebar is shown #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The style.css file was no longer loaded since the PDF viewer was adjusted to use the standard viewer app, so it can be removed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
When the Talk sidebar is shown the footer in public pages is moved into the "#app-content" element, so this needs to be taken into account when hiding the footer element. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The main content minimum height is set in server styles to the full height minus the footer height. The PDF viewer hides the footer, so the minimum height was increased to the full height to ensure that the main content took all the available space. However, when the Talk sidebar is shown, the page layout is also adjusted, including the CSS styles. As the minimum height was set on the element itself it took priority over the changes done by Talk, and caused the PDF viewer to end past the window bottom when the Talk sidebar is shown. No matter if the Talk sidebar is shown or not the main content height just needs to fill the available space, so now this is done using flexbox. This avoids having to set an explicit height and thus works for both the standard layout and the Talk sidebar layout. Moreover, even if an explicit height is set somewhere, like in the server or Talk styles, the flex-grow property implicitly overrides it and ensures that the main content will fill the available height. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
skjnldsv
approved these changes
Jun 28, 2022
skjnldsv
deleted the
backport/615/stable24-fix-footer-not-hidden-when-talk-sidebar-is-shown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Kind of) Backport of #615