Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Fix footer not hidden when Talk sidebar is shown #616

Commits on Jun 26, 2022

  1. Remove unused CSS file

    The style.css file was no longer loaded since the PDF viewer was
    adjusted to use the standard viewer app, so it can be removed.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Jun 26, 2022
    Configuration menu
    Copy the full SHA
    4e28a5b View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Fix footer not hidden when Talk sidebar is shown

    When the Talk sidebar is shown the footer in public pages is moved into
    the "#app-content" element, so this needs to be taken into account when
    hiding the footer element.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    96fcc79 View commit details
    Browse the repository at this point in the history
  2. Fix main content height when Talk sidebar is shown

    The main content minimum height is set in server styles to the full
    height minus the footer height. The PDF viewer hides the footer, so the
    minimum height was increased to the full height to ensure that the main
    content took all the available space.
    
    However, when the Talk sidebar is shown, the page layout is also
    adjusted, including the CSS styles. As the minimum height was set on the
    element itself it took priority over the changes done by Talk, and
    caused the PDF viewer to end past the window bottom when the Talk
    sidebar is shown.
    
    No matter if the Talk sidebar is shown or not the main content height
    just needs to fill the available space, so now this is done using
    flexbox. This avoids having to set an explicit height and thus works for
    both the standard layout and the Talk sidebar layout. Moreover, even if
    an explicit height is set somewhere, like in the server or Talk styles,
    the flex-grow property implicitly overrides it and ensures that the main
    content will fill the available height.
    
    Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    danxuliu committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    b903e03 View commit details
    Browse the repository at this point in the history