Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix scrolling for new design #1205

Closed
wants to merge 1 commit into from
Closed

Fix scrolling for new design #1205

wants to merge 1 commit into from

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 5, 2022

Signed-off-by: Louis Chemineau louis@chmn.me

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews labels Sep 5, 2022
@artonge artonge added this to the Nextcloud 25 milestone Sep 5, 2022
@artonge artonge self-assigned this Sep 5, 2022
@marcelklehr
Copy link
Member

TagContent and floders views are also broken. Not sure about On this day, favorites, people and shared with you

@artonge
Copy link
Collaborator Author

artonge commented Sep 5, 2022

TagContent and floders views are also broken. Not sure about On this day, favorites, people and shared with you

On this day and favorites are using the Timeline component so they are fixed by this PR. Can you push a fix for people and tags ? Should be the same logic as for Albums and AlbumContent

@@ -530,14 +531,13 @@ export default {
}

&__photos {
height: 100%;
height: calc(100% - 60px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes FileListViewer the scrollable element, but shouldn't the app content be the scrollable element?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, we probably need vue v7 for that, right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point, we don't really care which element is scrollable, no ?

@artonge
Copy link
Collaborator Author

artonge commented Sep 5, 2022

Superseded by #1206

@artonge artonge closed this Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants