Bump @nextcloud/vue to v7 #1206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
skjnldsv
force-pushed
the
bump/nextcloud_vue_7
branch
from
4e6785e to
84f83f6
Compare
skjnldsv
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Pushed a fix.
I removed the usage of NcTextField because it have a bug on the focus event it seems (focusing the input triggers the focus event more than one time for god know why. So let's keep it simple for now)
Albums have an horizontal scrollbar and a weird rendering data issue
We can fix it in a followup if you want
skjnldsv
reviewed
Sep 6, 2022
| <template> | ||
| <div v-if="isReady" class="emptycontent"> | ||
| <!-- eslint-disable-next-line vue/no-v-html (because it's an SVG file) --> | ||
| <div v-if="haveIllustration" class="illustration" v-html="illustration" /> |
There was a problem hiding this comment.
Seen, and on it ;) trying to abstract those views to have more consistency between them
marcelklehr
reviewed
Sep 8, 2022
|
|
||
| <!-- Folder content --> | ||
| <div v-else-if="!loading"> | ||
| <div class="photos-navigation"> | ||
| <Actions class="photos-navigation__back"> | ||
| <NcActions class="photos-navigation__back"> | ||
| <ActionButton @click="$router.push({name: 'tags'})"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.