Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Check upload directory share state #2658

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 25, 2024

Local version of #2657 for CI.

Done:

  • Block upload to the album DAV endpoint if the current user does not own the photo folder.
  • Add warning in Photos picker dialog. An alternative would be to hide the button. But uploads cannot be blocked as they are done directly to the DAV files endpoint, so it is impossible to distinguish from a legitimate upload.

Screenshot from 2024-09-25 14-40-42

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge added enhancement New feature or request 3. to review Waiting for reviews php PHP related ticket javascript Javascript related ticket labels Sep 25, 2024
@artonge artonge added this to the Nextcloud 31 milestone Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable30

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable29

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable28

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable27

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable26

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable25

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/compile /

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@artonge artonge merged commit 1b9afce into master Sep 25, 2024
44 checks passed
@artonge artonge deleted the artonge/fix/check_upload_folder_share_state branch September 25, 2024 16:45
Copy link

backportbot bot commented Sep 25, 2024

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b backport/2658/stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3d5562b8 5d116992

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2658/stable25

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Copy link

backportbot bot commented Sep 25, 2024

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b backport/2658/stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 3d5562b8 5d116992

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/2658/stable26

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

This comment was marked as resolved.

@artonge

This comment was marked as duplicate.

@artonge

This comment was marked as duplicate.

This comment was marked as resolved.

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews backport-request Pending backport by the backport-bot enhancement New feature or request javascript Javascript related ticket php PHP related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants