Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Use user uid to compare in PhotosPicker #2662

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix: Use user uid to compare in PhotosPicker #2662

merged 1 commit into from
Sep 26, 2024

Conversation

artonge
Copy link
Collaborator

@artonge artonge commented Sep 25, 2024 •
edited
Loading

@artonge artonge self-assigned this Sep 25, 2024
@artonge artonge added bug Something isn't working 3. to review Waiting for reviews javascript Javascript related ticket labels Sep 25, 2024
@artonge artonge added this to the Nextcloud 31 milestone Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable30

@artonge
Copy link
Collaborator Author

artonge commented Sep 25, 2024

/backport to stable29

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Sep 25, 2024
@artonge
Copy link
Collaborator Author

artonge commented Sep 26, 2024

/compile amend /

provokateurin
provokateurin reviewed Sep 26, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the compiled assets look a bit weird to me given the actual code changes 🤔

@artonge @nextcloud-command
fix: Use user uid to compare in PhotosPicker
1f82c6f 
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
provokateurin
provokateurin approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍

@artonge artonge merged commit 6f07e3c into master Sep 26, 2024
42 checks passed
@artonge artonge deleted the artonge/fix/missing_uid branch September 26, 2024 08:52
This was referenced Sep 26, 2024
Merged
Merged
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@provokateurin provokateurin provokateurin approved these changes

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews bug Something isn't working javascript Javascript related ticket
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@artonge @provokateurin