fix adding additional admins #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/Admins.vue
Outdated
| @@ -47,6 +49,11 @@ export default { | |||
| isAdding: false, | |||
| isSavingChanges: false | |||
| }), | |||
| computed: { | |||
| additionalAdminPlaceholderLabel() { | |||
| return t('privacy', 'Add outside admin') | |||
There was a problem hiding this comment.
"Add external admin/person" might sound a bit better but this is just a nitpick
9 tasks
|
let me quickly rebase and update the string as you suggested. |
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
georgehrke
force-pushed
the
bugfix/noid/fix_adding_additional_admins
branch
from
3670985 to
538b344
Compare
ChristophWurst
approved these changes
Apr 2, 2019
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, clicking the plus in the admin list had no effect. (not sure what caused this,
v-click-outsideshould not be triggered since it's inside an element withv-if)This pull-request makes sure that
v-click-outsideis not triggered by the click on the plus button.