How to merge "Where is your data?" and privacy app

[MorrisJobke]

In #13097 there as a section added to the personal settings, that optionally (if set) shows where your data is. This looks like that and was developed by @weeman1337 - thanks for this 👍 For all of the values there is just a plain text field (except for the admin to choose from).

In parallel @georgehrke (asked for by @karlitschek) created a little app that shows beside this basic data also some text about privacy and the user data manifesto in a separate app, that looks like this. It automatically determines the admin and shows all users you shared with.

@nextcloud/designers Do you have a clever way of combining those two apps into one? Both have nice features that are helpful, but keeping both is too much. The plan was to ship the privacy app. Any ideas?

• pro "Where is your data?":
  • input for company website and T&C
  • selection for admin to contact (email address of that user is automatically linked)
  • configuration integrated in theming section
• pro "privacy app":
  • further text in a separate section that explains the background
  • automatic listing of admins and users you shared with

cc @rullzer

[weeman1337]

@georgehrke emailed me, that he is working on merging "Where is your data?" into the app.

Things I would like to see there is whether server side encryption is enabled and info about the provider. It could be alongside the map where it says "Your date is located in XY hosted by ZZ."

[jancborchardt]

@weeman1337 Sorry about the communication issues btw. :\ Hope we get a solution which is cool for everyone. :)

Few points:

• We should not say "my", but "your". "Where is your data". Change "my" to "your" privacy#57
• Needs proofreading … capital "YOUR" is a bit much, and the exclamation mark etc. (am on vacation atm so can only leave this drive-by comment) Change "my" to "your" privacy#57
• "User Data Manifesto" needs to be properly capitalized Capitalize User Data Manifesto privacy#58
• I’d put the map on the bottom of the page because it is so big. And put the country name above the map. Fix the sections order, show the map last privacy#59
• What is the big + icon inside the "Who has access to your data?" fix adding additional admins privacy#77
• Agree with @weeman1337 on the encryption app status Add encryption status privacy#68
• Also @weeman1337’s work on adding privacy policy etc should be integrated. Add a privacy policy link if it's set privacy#75
• Then I’m fine moving it to a specific "Privacy" section and out of the "Profile info" completely. done by the privacy app

[rullzer]

I'm fine with the encryption status. But we should somehow add more text (I'll try to think of something). Because it might also give a false sense of security.

[ChristophWurst]

Shall we revert #13097 then?

[rullzer]

Shall we revert #13097 then?

guess so, probably just getting rid of the serverinfo part is easier... and less likely do break other things 😉

[ChristophWurst]

Also @weeman1337’s work on adding privacy policy etc should be integrated.

IMO we should just use the privacy policy URL from theming instead of duplicating that

[ChristophWurst]

It's ugly, but we can read the privacy URL from theming:

server/lib/private/URLGenerator.php

Lines 182 to 189 in b8fcf6e

	$themingEnabled = $this->config->getSystemValue('installed', false) && \OCP\App::isEnabled('theming') && \OC_App::isAppLoaded('theming');
	$themingImagePath = false;
	if($themingEnabled) {
	$themingDefaults = \OC::$server->getThemingDefaults();
	if ($themingDefaults instanceof ThemingDefaults) {
	$themingImagePath = $themingDefaults->replaceImagePath($app, $image);
	}
	}

[rullzer]

I moved them to separate issue in https://github.com/nextcloud/privacy

@ChristophWurst I'd be fine with a hacky way for now.

[ChristophWurst]

I think we can close this ticket here now that the server part was reverted and the privacy app contains most features. nextcloud/privacy#68 is the only pending feature as far as I can tell.