Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Where is your data?" #14753

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Revert "Where is your data?" #14753

merged 2 commits into from
Mar 20, 2019

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Mar 19, 2019

Reverts #13097

For #14738

Lets see what CI says..

@rullzer rullzer added this to the Nextcloud 16 milestone Mar 19, 2019
ChristophWurst
ChristophWurst previously requested changes Mar 20, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autoloader needs a bump

@ChristophWurst ChristophWurst added the 2. developing Work in progress label Mar 20, 2019
@ChristophWurst

This comment has been minimized.

Sign in to view
@MorrisJobke MorrisJobke mentioned this pull request Mar 20, 2019
Merged
9 tasks
ChristophWurst
ChristophWurst reviewed Mar 20, 2019
View reviewed changes
apps/theming/appinfo/info.xml
@@ -23,5 +23,6 @@

<settings>
<admin>OCA\Theming\Settings\Admin</admin>
<admin-section>OCA\Theming\Settings\Section</admin-section>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ref #14402 😉

ChristophWurst
ChristophWurst approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine 👍

@rullzer rullzer force-pushed the revert-13097-feature/11319/where-is-your-data branch from e19459d to 8b21c5e Compare March 20, 2019 15:29
@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 20, 2019
@rullzer rullzer requested a review from MorrisJobke March 20, 2019 15:29
@rullzer
Copy link
Member Author

rullzer commented Mar 20, 2019

Rebased to make the fixup bot happy

MorrisJobke
MorrisJobke approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 20, 2019
@nextcloud nextcloud deleted a comment from faily-bot bot Mar 20, 2019
@rullzer rullzer merged commit b72d270 into master Mar 20, 2019
@rullzer rullzer deleted the revert-13097-feature/11319/where-is-your-data branch March 20, 2019 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @ChristophWurst @MorrisJobke