Skip to content
Back to pull request #41088

enh(TextProcessing): Allow providers and task types to declare a dynamic ID instead of using className #33154

Sign in to view logs

enh(TextProcessing): Allow providers and task types to declare a dynamic ID instead of using className

enh(TextProcessing): Allow providers and task types to declare a dynamic ID instead of using className #33154

Triggered via pull request October 24, 2023 12:43
@marcelklehrmarcelklehr
opened #41088
enh/text-processing-provider-with-id
Status Failure
Total duration 1h 30m 29s
Artifacts –

static-code-analysis.yml

on: pull_request
static-code-analysis
4m 46s
static-code-analysis
static-code-analysis-security
7m 51s
static-code-analysis-security
static-code-analysis-ocp
2m 57s
static-code-analysis-ocp
Fit to window
Zoom out
Zoom in

Annotations

16 errors
MissingTemplateParam: lib/public/TextProcessing/IProviderWithId.php#L32
lib/public/TextProcessing/IProviderWithId.php:32:35: MissingTemplateParam: OCP\TextProcessing\IProviderWithId has missing template params when extending OCP\TextProcessing\IProvider, expecting 1 (see https://psalm.dev/182)
static-code-analysis-ocp
Process completed with exit code 2.
MoreSpecificReturnType: lib/private/TextProcessing/Manager.php#L99
lib/private/TextProcessing/Manager.php:99:43: MoreSpecificReturnType: The declared return type 'array<array-key, class-string<OCP\TextProcessing\ITaskType>>' for OC\TextProcessing\Manager::getAvailableTaskTypes is more specific than the inferred return type 'list<string>' (see https://psalm.dev/070)
LessSpecificReturnStatement: lib/private/TextProcessing/Manager.php#L104
lib/private/TextProcessing/Manager.php:104:10: LessSpecificReturnStatement: The type 'list<string>' is more general than the declared return type 'array<array-key, class-string<OCP\TextProcessing\ITaskType>>' for OC\TextProcessing\Manager::getAvailableTaskTypes (see https://psalm.dev/129)
MissingTemplateParam: lib/public/TextProcessing/IProviderWithId.php#L32
lib/public/TextProcessing/IProviderWithId.php:32:35: MissingTemplateParam: OCP\TextProcessing\IProviderWithId has missing template params when extending OCP\TextProcessing\IProvider, expecting 1 (see https://psalm.dev/182)
static-code-analysis
Process completed with exit code 2.
TaintedHtml: apps/admin_audit/lib/Actions/Action.php#L62
apps/admin_audit/lib/Actions/Action.php:62:16: TaintedHtml: Detected tainted HTML (see https://psalm.dev/245)
TaintedCallable: apps/files_external/lib/Config/ConfigAdapter.php#L74
apps/files_external/lib/Config/ConfigAdapter.php:74:50: TaintedCallable: Detected tainted text (see https://psalm.dev/243)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L247
apps/files_external/lib/Lib/Storage/SFTP.php:247:17: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L268
apps/files_external/lib/Lib/Storage/SFTP.php:268:19: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/files_external/lib/Lib/Storage/SFTP.php#L413
apps/files_external/lib/Lib/Storage/SFTP.php:413:22: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedCookie: apps/files_sharing/lib/Controller/ShareController.php#L463
apps/files_sharing/lib/Controller/ShareController.php:463:35: TaintedCookie: Detected tainted cookie (see https://psalm.dev/257)
TaintedFile: apps/theming/lib/IconBuilder.php#L137
apps/theming/lib/IconBuilder.php:137:40: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedFile: apps/theming/lib/IconBuilder.php#L235
apps/theming/lib/IconBuilder.php:235:28: TaintedFile: Detected tainted file handling (see https://psalm.dev/255)
TaintedHeader: lib/base.php#L204
lib/base.php:204:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)
TaintedHeader: lib/base.php#L286
lib/base.php:286:12: TaintedHeader: Detected tainted header (see https://psalm.dev/256)