Skip to content

Commit

Permalink
Merge pull request #36203 from nextcloud/enh/a11y-search-menu
Browse files Browse the repository at this point in the history
Port global search menu to focus trapped NcHeaderMenu
  • Loading branch information
skjnldsv committed Jan 19, 2023
2 parents aaf759b + 966872f commit eb40c06
Show file tree
Hide file tree
Showing 7 changed files with 22 additions and 260 deletions.
238 changes: 0 additions & 238 deletions core/src/components/HeaderMenu.vue

This file was deleted.

30 changes: 16 additions & 14 deletions core/src/views/UnifiedSearch.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
-
-->
<template>
<HeaderMenu id="unified-search"
<NcHeaderMenu id="unified-search"
class="unified-search"
exclude-click-outside-classes="popover"
:open.sync="open"
Expand Down Expand Up @@ -150,24 +150,26 @@
</li>
</ul>
</template>
</HeaderMenu>
</NcHeaderMenu>
</template>

<script>
import debounce from 'debounce'
import { emit, subscribe, unsubscribe } from '@nextcloud/event-bus'
import { minSearchLength, getTypes, search, defaultLimit, regexFilterIn, regexFilterNot, enableLiveSearch } from '../services/UnifiedSearchService'
import { showError } from '@nextcloud/dialogs'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton'
import NcActions from '@nextcloud/vue/dist/Components/NcActions'
import debounce from 'debounce'
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent'
import NcHighlight from '@nextcloud/vue/dist/Components/NcHighlight'
import Magnify from 'vue-material-design-icons/Magnify'
import NcActionButton from '@nextcloud/vue/dist/Components/NcActionButton.js'
import NcActions from '@nextcloud/vue/dist/Components/NcActions.js'
import NcEmptyContent from '@nextcloud/vue/dist/Components/NcEmptyContent.js'
import NcHeaderMenu from '@nextcloud/vue/dist/Components/NcHeaderMenu.js'
import NcHighlight from '@nextcloud/vue/dist/Components/NcHighlight.js'
import Magnify from 'vue-material-design-icons/Magnify.vue'
import HeaderMenu from '../components/HeaderMenu'
import SearchResult from '../components/UnifiedSearch/SearchResult'
import SearchResultPlaceholders from '../components/UnifiedSearch/SearchResultPlaceholders'
import SearchResult from '../components/UnifiedSearch/SearchResult.vue'
import SearchResultPlaceholders from '../components/UnifiedSearch/SearchResultPlaceholders.vue'
import { minSearchLength, getTypes, search, defaultLimit, regexFilterIn, regexFilterNot, enableLiveSearch } from '../services/UnifiedSearchService.js'
const REQUEST_FAILED = 0
const REQUEST_OK = 1
Expand All @@ -177,12 +179,12 @@ export default {
name: 'UnifiedSearch',
components: {
Magnify,
NcActionButton,
NcActions,
NcEmptyContent,
HeaderMenu,
NcHeaderMenu,
NcHighlight,
Magnify,
SearchResult,
SearchResultPlaceholders,
},
Expand Down
4 changes: 2 additions & 2 deletions dist/core-common.js

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions dist/core-common.js.LICENSE.txt
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,6 @@ object-assign

/*! For license information please see NcTextField.js.LICENSE.txt */

/*! For license information please see excludeClickOutsideClasses.js.LICENSE.txt */

/*! For license information please see index.module.js.LICENSE.txt */

/*! Hammer.JS - v2.0.7 - 2016-04-22
Expand Down
2 changes: 1 addition & 1 deletion dist/core-common.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dist/core-unified-search.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/core-unified-search.js.map

Large diffs are not rendered by default.

0 comments on commit eb40c06

Please sign in to comment.