Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port global search menu to focus trapped NcHeaderMenu #36203

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Port global search menu to focus trapped NcHeaderMenu #36203

merged 1 commit into from
Jan 19, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Jan 18, 2023 •
edited
Loading

Summary

Tabbing after hitting the last result will loop back focus to the search input

No visual changes 🔎
image

Checklist

@Pytal Pytal added this to the Nextcloud 26 milestone Jan 18, 2023
@Pytal Pytal self-assigned this Jan 18, 2023
@Pytal
Copy link
Member Author

Pytal commented Jan 18, 2023

/backport to stable25

@Pytal Pytal mentioned this pull request Jan 18, 2023
Closed
2 tasks
@nickvergessen
Copy link
Member

nickvergessen commented Jan 18, 2023 •
edited by skjnldsv
Loading

I added back the pull request template you accidentally removed.

Screenshots before/after for front-end changes

Can you add the screenshots, even if they are supposed to look the same?

@Pytal
Port global search menu to focus trapped NcHeaderMenu
966872f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Jan 18, 2023

I added back the pull request template you accidentally removed.

Screenshots before/after for front-end changes

Can you add the screenshots, even if they are supposed to look the same?

Done! Also removed the link to prevent having to reopen for the backport

skjnldsv
skjnldsv approved these changes Jan 19, 2023
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! 🚀

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 19, 2023
@skjnldsv skjnldsv merged commit eb40c06 into master Jan 19, 2023
@skjnldsv skjnldsv deleted the enh/a11y-search-menu branch January 19, 2023 07:25
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 19, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

@GretaD GretaD Awaiting requested review from GretaD

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility enhancement feature: search
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@Pytal @nickvergessen @skjnldsv