Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted file expiry date #107

Closed
williambargent opened this issue Jun 15, 2016 · 19 comments
Closed

Deleted file expiry date #107

williambargent opened this issue Jun 15, 2016 · 19 comments
Labels

Comments

@williambargent
Copy link
Member

williambargent commented Jun 15, 2016

Steps to reproduce

  1. Deleted a file
  2. View recycle bin

Expected behaviour

Many installations have the ''trashbin_retention_obligation' => 30,'
In the bin it should show when the file will be automatically deleted; have a timer;

Actual behaviour

Doesn't notify users the bin will be cleared.

Thoughts @nextcloud/designers

capture

@BernhardPosselt
Copy link
Member

BernhardPosselt commented Jun 15, 2016

Please don't use nextcloud/developers ;)

@janklostermann
Copy link

Very cool. Should be there!

Von unterwegs gesendet. Sent from my phone. 

-------- Ursprüngliche Nachricht --------
Von: William Bargent notifications@github.com
Datum:15.06.2016 12:24 (GMT+01:00)
An: nextcloud/server server@noreply.github.com
Cc: janklostermann jk@janklostermann.de,Team mention team_mention@noreply.github.com
Betreff: [nextcloud/server] Feature Request: Deleted file expiry date (#107)

Steps to reproduce

Deleted a file
View recycle bin
Expected behaviour

Many installations have the ''trashbin_retention_obligation' => 30,'
In the bin it should show when the file will be automatically deleted; have a timer;

Actual behaviour

Doesn't notify users the bin will be cleared.

Thoughts @nextcloud/designers
cc @nextcloud/developers


You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

@jancborchardt
Copy link
Member

@janklostermann Github since recently has a »reaction« feature (in the top right behind the smilie face). If you want to express agreement, please use that one for »thumbs-up« like comments instead of leaving an actual comment which results in notifying everyone involved. Thanks! :)

@le-fractal
Copy link

I'm not a fan of this feature, because if you see something in the trash that shouldn't be there, you should take it out immediately.

I can't think of any scenario that would make me think "I still have 2 days to decide if I really want to lose this file". Having that timer implies that it's somehow "safe" to trash files.

@jancborchardt
Copy link
Member

@zinks- good point. I am also hesitant of adding another column there if it’s not absolutely necessary. The list view should not be a database dump. :)

@MorrisJobke
Copy link
Member

I second the argument of @zinks-. @williambargent What is the exact use case of this column for you?

@janklostermann
Copy link

Transparency of what is going on (including an implicit warning, that
this data will automatically be deleted soon - different to your Windows
trash bin that seems to have ethernal life...)

Am 2016-06-16 um 11:08 schrieb Morris Jobke:

I second the argument of @zinks- https://github.com/zinks-.
@williambargent https://github.com/williambargent What is the exact
use case of this column for you?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#107 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ALEnw5RqqlUHOVWTB2r0emWg5rSi3kM3ks5qMRJ1gaJpZM4I2Nd-.

Jan Klostermann

  • The Agile Management Sounding-Board -
    Systems Engineer & Mediator
    Am Isarkanal 24/15
    81379 München

Tel.: +49-89/74563382
Mobil: +49-179/4628819
Sip: +49-89/21551663 sip:08921551663@sipgate.de
Skype: jan.klostermann callto://jan.klostermann/
Threema: P58VSJUY threema://add?id=P58VSJUY
Email: jk@janklostermann.de mailto:jk@janklostermann.de
Netzwerke: Xing https://www.xing.com/profile/Jan_Klostermann, LinkedIn
http://de.linkedin.com/in/janklostermann

@williambargent
Copy link
Member Author

williambargent commented Jun 16, 2016

Users are unaware they won't be able to recover a file, I understand that they deleted it but its nice to know when the recycle bin will be automatically emptied. To me its just a nice bit of information to know.

@jakobsack
Copy link
Member

Well, we could add a text at the top of the page stating "Files in the trash bin will be unrecoverable deleted after -x- days." Combined with the "deleted"-column the user is able to see which files are near expiration. In my opinion this is a good compromise because it warns the user but does not clutter the interface too much.

@jancborchardt
Copy link
Member

Well, this is only the case for certain setups. The assumption in the original post says:

Many installations have the ''trashbin_retention_obligation' => 30,'

But since this is not the default setting, it’s unlikely to be »many« and more likely to be »some« or even »a few«.

@jakobsack
Copy link
Member

Well, this is only the case for certain setups

Of course there should be no text if there is no expiration date.

@MorrisJobke
Copy link
Member

Of course there should be no text if there is no expiration date.

Then the expiration is also calculated on how much storage is used (in relation to the quota). If this is reached the files are removed from the trashbin that are in there for the longest time.

@jakobsack
Copy link
Member

ok, in this case my proposal is pointless

@janklostermann
Copy link

janklostermann commented Jun 16, 2016

In these cases the column could disappear...

@williambargent
Copy link
Member Author

I wasn't area of that so yeah seems silly having it, if the value is set I still think it is worth it being mentioned somewhere on the page.

@MariusBluem MariusBluem changed the title Feature Request: Deleted file expiry date Deleted file expiry date Jul 28, 2016
@coderkun
Copy link
Contributor

If there are other triggers that might delete files in the trash permanently (e. g. storage exceeded), showing the expiration date will be misleading because it is only one of several triggers. A user might think that a file will not be deleted before that date—which is not true if one of the other triggers take effect.

But a message telling the user that there are triggers that might delete files permanently—which ones and in case of the expiration date the max. days—would be great. Especially since the administrator is setting and controlling these settings and not the user itself.

@szaimen
Copy link
Contributor

szaimen commented May 21, 2021

I'm closing this issue due to inactivity. Please reopen if you still want to implement this.

@szaimen szaimen closed this as completed May 21, 2021
@enoch85 enoch85 reopened this May 21, 2021
@enoch85
Copy link
Member

enoch85 commented May 21, 2021

Cool feature!

@CarlSchwan
Copy link
Member

Closing since this is a feature request and there is doubt about its entire usability of it. Also, this is not trivial to implement.

If someone want to implement it, PR welcome and we can discuss details there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests