-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deleted file expiry date #107
Comments
Please don't use nextcloud/developers ;) |
Very cool. Should be there! Von unterwegs gesendet. Sent from my phone. -------- Ursprüngliche Nachricht -------- Steps to reproduce Deleted a file Many installations have the ''trashbin_retention_obligation' => 30,' Actual behaviour Doesn't notify users the bin will be cleared. Thoughts @nextcloud/designers — |
@janklostermann Github since recently has a »reaction« feature (in the top right behind the smilie face). If you want to express agreement, please use that one for »thumbs-up« like comments instead of leaving an actual comment which results in notifying everyone involved. Thanks! :) |
I'm not a fan of this feature, because if you see something in the trash that shouldn't be there, you should take it out immediately. I can't think of any scenario that would make me think "I still have 2 days to decide if I really want to lose this file". Having that timer implies that it's somehow "safe" to trash files. |
@zinks- good point. I am also hesitant of adding another column there if it’s not absolutely necessary. The list view should not be a database dump. :) |
I second the argument of @zinks-. @williambargent What is the exact use case of this column for you? |
Transparency of what is going on (including an implicit warning, that Am 2016-06-16 um 11:08 schrieb Morris Jobke:
Jan Klostermann
Tel.: +49-89/74563382 |
Users are unaware they won't be able to recover a file, I understand that they deleted it but its nice to know when the recycle bin will be automatically emptied. To me its just a nice bit of information to know. |
Well, we could add a text at the top of the page stating "Files in the trash bin will be unrecoverable deleted after -x- days." Combined with the "deleted"-column the user is able to see which files are near expiration. In my opinion this is a good compromise because it warns the user but does not clutter the interface too much. |
Well, this is only the case for certain setups. The assumption in the original post says:
But since this is not the default setting, it’s unlikely to be »many« and more likely to be »some« or even »a few«. |
Of course there should be no text if there is no expiration date. |
Then the expiration is also calculated on how much storage is used (in relation to the quota). If this is reached the files are removed from the trashbin that are in there for the longest time. |
ok, in this case my proposal is pointless |
In these cases the column could disappear... |
I wasn't area of that so yeah seems silly having it, if the value is set I still think it is worth it being mentioned somewhere on the page. |
If there are other triggers that might delete files in the trash permanently (e. g. storage exceeded), showing the expiration date will be misleading because it is only one of several triggers. A user might think that a file will not be deleted before that date—which is not true if one of the other triggers take effect. But a message telling the user that there are triggers that might delete files permanently—which ones and in case of the expiration date the max. days—would be great. Especially since the administrator is setting and controlling these settings and not the user itself. |
I'm closing this issue due to inactivity. Please reopen if you still want to implement this. |
Cool feature! |
Closing since this is a feature request and there is doubt about its entire usability of it. Also, this is not trivial to implement. If someone want to implement it, PR welcome and we can discuss details there |
Steps to reproduce
Expected behaviour
Many installations have the ''trashbin_retention_obligation' => 30,'
In the bin it should show when the file will be automatically deleted; have a timer;
Actual behaviour
Doesn't notify users the bin will be cleared.
Thoughts @nextcloud/designers
The text was updated successfully, but these errors were encountered: