Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#app-navigation-toggle missing #14956

Closed
ChristophWurst opened this issue Apr 4, 2019 · 1 comment
Closed

#app-navigation-toggle missing #14956

ChristophWurst opened this issue Apr 4, 2019 · 1 comment
Assignees
@ChristophWurst
Labels
3. to review Waiting for reviews bug help wanted
Milestone
Nextcloud 16

Comments

@ChristophWurst
Copy link
Member

Steps to reproduce

  1. Install an app that does not render it's full structure right away on page load (works with Mail v0.12.0-RC3)
  2. Load the page with a bandwidth throttler (from the FF dev console for example) with a mobile resolution (narrow screen)

Expected behaviour

See the #app-navigation-toggle injected (a burger menu to toggle the navigation on mobile) as documented at https://docs.nextcloud.com/server/15/developer_manual/design/content.html

Actual behaviour

See no icon

Server configuration

Nextcloud version: 15 & 16

cc @nextcloud/javascript
@ChristophWurst ChristophWurst added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 1. to develop Accepted and waiting to be taken care of help wanted and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Apr 4, 2019
@ChristophWurst
Copy link
Member Author

Contacts show the content details right away: no problem
Mail starts with a loading screen: 💥

@ChristophWurst ChristophWurst added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Apr 5, 2019
@ChristophWurst ChristophWurst self-assigned this Apr 5, 2019
ChristophWurst added a commit that referenced this issue Apr 5, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
3b6ee4b 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added this to the Nextcloud 16 milestone Apr 5, 2019
This was referenced Apr 5, 2019
Merged
Closed
ChristophWurst added a commit that referenced this issue Apr 9, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
0687d17 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this issue Apr 10, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
0178ac5 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this issue Apr 10, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
708491a 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst added a commit that referenced this issue Apr 10, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
0871b9a 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
backportbot-nextcloud bot pushed a commit that referenced this issue Apr 11, 2019
@ChristophWurst
Do not inject a #app-navigation-toggle if there is already one
b0987b2 
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.

Fixes #14956

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChristophWurst ChristophWurst

Labels
3. to review Waiting for reviews bug help wanted
Projects
None yet
Milestone
Nextcloud 16
Development

No branches or pull requests
1 participant
@ChristophWurst