Disable the injected snapper logic when apps want to ship their own #14972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
added
bug
design
ChristophWurst
requested review from
MorrisJobke,
rullzer,
juliusknorr and
nickvergessen
ChristophWurst
added
1. to develop
Put on hold as long as I don't know if this really works. |
skjnldsv
reviewed
Apr 5, 2019
ChristophWurst
force-pushed
the
fix/app-nav-toggle-missing
branch
from
3b6ee4b to
0687d17
Compare
ChristophWurst
force-pushed
the
fix/app-nav-toggle-missing
branch
2 times, most recently
from
0178ac5 to
708491a
Compare
This allows apps to ship their own, as in some cases the #app-content element does not exist on page load and therefore the injection fails and the icon is missing afterwards. Fixes #14956 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/app-nav-toggle-missing
branch
from
708491a to
0871b9a
Compare
ChristophWurst
changed the title
ChristophWurst
added
3. to review
skjnldsv
approved these changes
Apr 10, 2019
|
Please document this in the developer documentation. |
MorrisJobke
added
4. to release
|
@MorrisJobke this will be for the vue components only while we transition. |
Okay |
|
@ChristophWurst Backport to what branch? |
|
at least to 15. @skjnldsv opinions? |
|
/backport to stable15 |
|
backport to stable15 in #15046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows apps to ship their own, as in some cases the #app-content
element does not exist on page load and therefore the injection fails
and the icon is missing afterwards.
With nextcloud-libraries/nextcloud-vue#339 we'll ship our own Vue-specific logic to handle the sliding.
Fixes #14956