Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot delete group with a slash in its name #2954

Closed
hirschrobert opened this issue Jan 5, 2017 · 7 comments · Fixed by #4138
Closed

cannot delete group with a slash in its name #2954

hirschrobert opened this issue Jan 5, 2017 · 7 comments · Fixed by #4138

Comments

@hirschrobert
Copy link

hirschrobert commented Jan 5, 2017

Steps to reproduce

  1. create a group with a slash in its name
  2. try to delete that group

Expected behaviour

group should be deleted

Actual behaviour

group name vanishes but comes back after page refresh

Server configuration

Operating system:
debian

Web server:
apache 2.4

Database:
mysql 5.5.53

PHP version:
5.6.29

Nextcloud version: (see Nextcloud admin page)
10.0.2

Solutions?

Could have something to do with owncloud/core#24072

@nickvergessen
Copy link
Member

cc @LukasReschke you broke this :P

@nickvergessen nickvergessen added this to the Nextcloud 12.0 milestone Jan 5, 2017
rullzer added a commit that referenced this issue Mar 29, 2017
Fixes #2954

Before we could match on <prefix>/{id} however if the id contains a /
this would not match properly. But since we define the resource routes
internally we now make sure that we match all chars (up until the ?).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer added a commit that referenced this issue Apr 4, 2017
Fixes #2954

Before we could match on <prefix>/{id} however if the id contains a /
this would not match properly. But since we define the resource routes
internally we now make sure that we match all chars (up until the ?).

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@janekbettinger
Copy link

Using Nextcloud 13 I cannot delete a user group containing a slash although this bug should already be fixed.

  • Nextcloud 13.0.1
  • PHP 7.0.28
  • PostgreSQL 9.4.15 on x86_64-unknown-linux-gnu, compiled by gcc (Debian 4.9.2-10) 4.9.2, 64-bit

@OlJohnny
Copy link

OlJohnny commented May 11, 2018

I have just made a clean install of nextcloud 13.0.2 with apache2 (PHP-7.2.3) on ubuntu 18.04 with mySQL 5.7.22 and all the necessary php modules and have the same problem.
When I try to delete the group (with a "/" in the name), it says "Group deleted". But after a refresh of the page (as stated above) the group is still there.
BUT I can still add/remove persons to/from the group.

It also breaks the Group Folders app, as I cannot change permission and/or remove the group from a group folder.

@brknkfr
Copy link

brknkfr commented Sep 7, 2018

Problem still exists in Nextcloud 13.0.6, please reopen.

@OlJohnny
Copy link

OlJohnny commented Sep 7, 2018

Can confirm, that you are still unable to delete a group with a slash in its name in 13.0.6 (It gets displayed, that it works, but if you reopen the group site, it is displayed once again)

@kesselb
Copy link
Contributor

kesselb commented Sep 7, 2018

Management for a Group with / in name is broken for me. I cannot view users in there. Does this work for you?

@kesselb
Copy link
Contributor

kesselb commented Sep 7, 2018

['root' => '/cloud', 'name' => 'Groups#getGroupUsersDetails', 'url' => '/groups/{groupId}/users/details', 'verb' => 'GET'],

When i replace the line above with
['root' => '/cloud', 'name' => 'Groups#getGroupUsersDetails', 'url' => '/groups/{groupId}/users/details', 'verb' => 'GET', 'requirements' => ['groupId' => '.+']], than i can view groups with / inside

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants