-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: deleting file fails with 423: Locked
#42306
Comments
I find it interesting that the innermost exception complains about the entire storage being locked:
|
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
@come-nc you observed the same in |
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
cypress-1.log(1).zip |
Think CI on both nextcloud/groupfolders#2694 and nextcloud/groupfolders#2644 is failing because of this bug. |
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
nextcloud/server#42306 causes the DELETE request to fail with 423 Locked. Signed-off-by: Max <max@nextcloud.com>
For the tests in groupfolders, this was somehow fix by making sure the action menu showed up before clicking on the delete button. Maybe only because it slows a bit down requests? [EDIT] Actually not fixed, it still happens often |
Stack trace:
|
This entry is found where it expected lock to be 1 to be able to lock it exclusively. That would suggest something else is locking the file. What I do not get is why the path looks like that? |
It looks expected, it’s built in lib/private/Files/Storage/Common.php:833 |
Current theory: the loading of the preview locks the file and conflicts with the deletion. I’m gonna try waiting for preview to be loaded before attempting to delete files. |
@max-nextcloud nextcloud/groupfolders#2806 Waiting for preview to load seems to work, can you try? |
Looks like the tests are green again now. No idea why. Either way the server behavior is consistent with expectations for locking. So I will close this and in case we run into the failing tests again i will either disable the |
Tests went back to flaky - but waiting for preview did the trick! Thanks Come! ❤️ |
Bug description
An attachment test is failing in the
text
app CI for a while now. Similar failures happen in the groupfolders CI.When trying to delete a file that was created by the same test the server responds with:
Steps to reproduce
deleteFile
triggers aDELETE
onhttp://localhost:8081/remote.php/webdav/deleteMe.md
.Expected behavior
Delete works fine.
Installation method
Community Manual installation with Archive
Nextcloud Server version
28
Operating system
None
PHP engine version
None
Web server
None
Database engine version
None
Is this bug present after an update or on a fresh install?
Fresh Nextcloud Server install
Are you using the Nextcloud Server Encryption module?
Encryption is Disabled
What user-backends are you using?
Configuration report
No response
List of activated Apps
Nextcloud Signing status
No response
Nextcloud Logs
Additional info
The logs were optained by making the
FileLocked
error fatal:https://github.com/nextcloud/server/pull/42253/files
The text was updated successfully, but these errors were encountered: