Bring back test failing due to server issue #5144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-nextcloud
force-pushed
the
test/delete-with-attachment-again
branch
from
290976e
to
f4b642e
Compare
|
/backport to stable28 |
mejo-
force-pushed
the
test/delete-with-attachment-again
branch
from
f4b642e
to
ffe34b7
Compare
This reverts commit 77d7756. Signed-off-by: Max <max@nextcloud.com>
mejo-
force-pushed
the
test/delete-with-attachment-again
branch
from
ffe34b7
to
7668b68
Compare
mejo-
approved these changes
Mar 15, 2024
|
@mejo- Are you sure this one is fixed? Upstream issue is still open but it looks like the test was flaky because files could not be deleted during preview generation. Here's the actual fix for the tests in groupfolders: https://github.com/nextcloud/groupfolders/pull/2806/files#diff-916f4714b496997bded1e151f955f0ac5f76f562ad64c465e58b1c4f01589841R124-R130 |
|
@max-nextcloud to be honest I just rebased and saw that the tests passed. So I merged it. And I didn't see the test in question failing on |
Cool. As long as it stays green we're good then i guess. Otherwise we know where to look. I'll close the issue in server. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 77d7756.
Merge once
423: Lockedserver#42306is fixed.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)