Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Adding a second share link "renames" the first one #48415

Closed
4 of 8 tasks
Tracked by #5249
kesselb opened this issue Sep 26, 2024 · 1 comment · Fixed by #49017
Closed
4 of 8 tasks
Tracked by #5249

[Bug]: Adding a second share link "renames" the first one #48415

kesselb opened this issue Sep 26, 2024 · 1 comment · Fixed by #49017
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug feature: sharing

Comments

@kesselb
Copy link
Contributor

kesselb commented Sep 26, 2024

⚠️ This issue respects the following points: ⚠️

Bug description

Adding a second share link "renames" the existing share link.

If you reload the page, then the ordering is correct again.

Screencast.from.2024-09-26.22-18-54.webm

Steps to reproduce

  1. Add a share link for a folder, don't assign an extra label
  2. Click on three dots -> Add another link
  3. The new link is prepended to the list as "Share link" and the old one "renamed" to "Share link (2)"

Expected behavior

The other link should be added to the list as share link (2).

Nextcloud Server version

master

Operating system

None

PHP engine version

None

Web server

None

Database engine version

None

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@kesselb kesselb added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 30-feedback 1. to develop Accepted and waiting to be taken care of feature: sharing and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Sep 26, 2024
@kesselb
Copy link
Contributor Author

kesselb commented Sep 26, 2024

cc @susnux @skjnldsv @fenn-cs

@susnux susnux moved this to 📄 To do (~10 entries) in 📁 Files team Oct 30, 2024
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to begining of the share list in the UI messing
up the ordering with the original (first) looking like the most recent and
the most recent looking like the original share. This error disppears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI
messing up the ordering with the original (first) looking like the most
recent and the most recent looking like the original share. This error
disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI
messing up the ordering with the original (first) looking like the most
recent and the most recent looking like the original share. This error
disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📁 Files team Oct 30, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Oct 30, 2024
backportbot bot pushed a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
backportbot bot pushed a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
backportbot bot pushed a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>

[skip ci]
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Oct 30, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Altahrim pushed a commit that referenced this issue Oct 31, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
artonge pushed a commit that referenced this issue Oct 31, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
artonge pushed a commit that referenced this issue Oct 31, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nextcloud-command pushed a commit that referenced this issue Oct 31, 2024
Currently new shares are added to beginning of the share list in the UI

messing up the ordering with the original (first) looking like the most

recent and the most recent looking like the original share. This error

disappears on refresh.

Resolves : #48415

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug feature: sharing
Projects
Status: ☑️ Done
Development

Successfully merging a pull request may close this issue.

2 participants