-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ShareEntryLinkList): Append new links to the end of list #49017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nfebe
added
3. to review
Waiting for reviews
4. to release
Ready to be released and/or waiting for tests to finish
feature: sharing
labels
Oct 30, 2024
nfebe
force-pushed
the
fix/48415/do-not-rename-main-share-link
branch
from
October 30, 2024 13:55
105d803
to
3cee516
Compare
/backport to stable30 |
/backport to stable29 |
/backport to stable28 |
Currently new shares are added to beginning of the share list in the UI messing up the ordering with the original (first) looking like the most recent and the most recent looking like the original share. This error disappears on refresh. Resolves : #48415 Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/48415/do-not-rename-main-share-link
branch
from
October 30, 2024 13:57
3cee516
to
0daacbe
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Possible performance regression detected Show Output
|
susnux
approved these changes
Oct 30, 2024
artonge
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
4. to release
Ready to be released and/or waiting for tests to finish
feature: sharing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently new shares are added to beginning of the share list in the UI messing up the ordering with the original (first) looking like the most recent and the most recent looking like the original share. This error disappears on refresh.
Resolves : #48415