Print error on data dir error #17163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
…ble to view it Signed-off-by: Joas Schilling <coding@schilljs.com>
joshtrichards
added a commit
to joshtrichards/nc-server
that referenced
this pull request
Jun 16, 2023
Fixes nextcloud#2180 And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708 Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc. While we check for it later, it's too late for session. Inspired by nextcloud#17163 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
5 tasks
joshtrichards
added a commit
to joshtrichards/nc-server
that referenced
this pull request
Jun 16, 2023
Fixes nextcloud#2180 And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708 Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc. While we check for it later, it's too late for session. Inspired by nextcloud#17163 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
AndyScherzinger
pushed a commit
to joshtrichards/nc-server
that referenced
this pull request
Feb 27, 2024
Fixes nextcloud#2180 And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708 Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc. While we check for it later, it's too late for session. Inspired by nextcloud#17163 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
skjnldsv
pushed a commit
to joshtrichards/nc-server
that referenced
this pull request
Aug 16, 2024
Fixes nextcloud#2180 And prevents nextcloud#31473, nextcloud#23970, nextcloud#18610, nextcloud#15708 Avoids a 500 error and also gives a useful error message on the web interface if this module isn't installed, gets overlooked during a PHP upgrade, etc. While we check for it later, it's too late for session. Inspired by nextcloud#17163 Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chmod ugo-rwx -R data/)index.phpindex.php/apps/files(e.g. from a bookmarkBefore
After
Also I had an issue when my data dir is not mounted at all. So I added a second level fallback, when showing the error page also fails, we just print the plain messages.