when a user was deleted remove them from applicable list, unless... #17920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
rullzer,
nickvergessen,
icewind1991,
juliusknorr and
kesselb
blizzz
changed the title
nickvergessen
approved these changes
Nov 13, 2019
nickvergessen
requested changes
Nov 13, 2019
|
|
blizzz
added
3. to review
nickvergessen
requested changes
Nov 13, 2019
it is the only user, then remove the mount Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/15258/ext-storage-respect-deletion
branch
from
58da404 to
4baab51
Compare
|
@nickvergessen @icewind1991 can we get this in? |
icewind1991
approved these changes
Nov 29, 2019
nickvergessen
approved these changes
Dec 4, 2019
|
/backport to stable17 |
|
/backport to stable16 |
|
/backport to stable15 |
juliusknorr
reviewed
Dec 5, 2019
| $builder = $this->connection->getQueryBuilder(); | ||
| $query = $builder->select(['a.mount_id', $builder->func()->count('a.mount_id', 'count')]) | ||
| ->from('external_applicable', 'a') | ||
| ->rightJoin('a', 'external_applicable', 'b', $builder->expr()->eq('a.mount_id', 'b.mount_id')) |
There was a problem hiding this comment.
Right join was not supported on sqlite iirc
There was a problem hiding this comment.
turning it around seems to work, same table after all. PR incoming,
|
Breaks quite some integration tests: https://drone.nextcloud.com/nextcloud/server/23756/32/3 |
This was referenced Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it is the only user, then remove the mount
fixes #15258
@icewind1991 does it make sense to you?