Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add id to editor of direct editing #18242

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Conversation

tobiasKaminsky
Copy link
Member

@juliushaertl

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@juliusknorr juliusknorr added 3. to review Waiting for reviews bug labels Dec 5, 2019
@juliusknorr juliusknorr added this to the Nextcloud 18 milestone Dec 5, 2019
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 5, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Dec 5, 2019

lots of integration failure?

@rullzer
Copy link
Member

rullzer commented Dec 5, 2019

mmm "General error: 1 RIGHT and FULL OUTER JOINs are not currently supported" like wut....

@juliusknorr
Copy link
Member

@juliusknorr
Copy link
Member

Seems like #17920 caused this

@rullzer rullzer merged commit 4bf5a23 into master Dec 5, 2019
@rullzer rullzer deleted the directEditingEditorWithId branch December 5, 2019 18:48
@rullzer rullzer mentioned this pull request Dec 11, 2019
43 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants