-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not exit if available space cannot be determined on file transfer #21775
Conversation
For the record: -2 is "space unknown": server/lib/public/Files/FileInfo.php Line 57 in cb05782
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with me
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
82c25d6
to
4e297d7
Compare
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 31585: failureacceptance-app-files
Show full log
|
/backport to stable19 |
/backport to stable18 |
/backport to stable17 |
The backport to stable17 failed. Please do this backport manually. |
Otherwise transfering files on primary object storage fails as the free space cannot be determined. I'm not fully sure if there are other cases where a -2 might happen for the free_space call and where we should then block file transfer but I think it makes sense to just allow it in such cases.