Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable19] Do not exit if available space cannot be determined on file transfer #22181

Merged
merged 2 commits into from
Aug 13, 2020
Merged

[stable19] Do not exit if available space cannot be determined on file transfer #22181

merged 2 commits into from
Aug 13, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #21775

juliusknorr and others added 2 commits August 11, 2020 09:20
@juliusknorr @backportbot
Do not exit if available space cannot be determined on file transfer
3606b4a 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@MorrisJobke @backportbot
Use constant instead of magic number
7f49492 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 19.0.2 milestone Aug 11, 2020
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Aug 11, 2020
@faily-bot
Copy link

faily-bot bot commented Aug 11, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 31603: failure

mariadb10.1-php7.2

Show full log 
There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #93 ('folder', 19, 23)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:366

mysql5.6-php7.2

Show full log 
There was 1 error:

1) OCA\Files_Sharing\Tests\ShareTest::testUnshareFromSelf
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:304
/drone/src/lib/private/Share20/Manager.php:705
/drone/src/apps/files_sharing/tests/TestCase.php:255
/drone/src/apps/files_sharing/tests/ShareTest.php:84

integration-provisioning-v2

  • build/integration/features/provisioning-v2.feature:22
Show full log 
  Scenario: Searching by displayname in groups                                                    # /drone/src/build/integration/features/provisioning-v2.feature:22
    Given As an "admin"                                                                           # FeatureContext::asAn()
[Tue Aug 11 10:50:24 2020] 127.0.0.1:55358 [404]: /ocs/v2.php/cloud/users/user-in-group
[Tue Aug 11 10:50:25 2020] 127.0.0.1:55370 [200]: /ocs/v2.php/cloud/users
[Tue Aug 11 10:50:25 2020] 127.0.0.1:55386 [200]: /ocs/v2.php/cloud/users/user-in-group
[Tue Aug 11 10:50:25 2020] 127.0.0.1:55398 [200]: /ocs/v2.php/cloud/users/user-in-group
    And user "user-in-group" with displayname "specific-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Tue Aug 11 10:50:25 2020] 127.0.0.1:55406 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Tue Aug 11 10:50:26 2020] 127.0.0.1:55416 [200]: /ocs/v2.php/cloud/users
[Tue Aug 11 10:50:27 2020] 127.0.0.1:55446 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Tue Aug 11 10:50:27 2020] 127.0.0.1:55460 [200]: /ocs/v2.php/cloud/users/user-in-group2
    And user "user-in-group2" with displayname "another-name" exists                              # FeatureContext::assureUserWithDisplaynameExists()
[Tue Aug 11 10:50:27 2020] 127.0.0.1:55482 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Tue Aug 11 10:50:28 2020] 127.0.0.1:55486 [200]: /ocs/v2.php/cloud/users
[Tue Aug 11 10:50:28 2020] 127.0.0.1:55528 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Tue Aug 11 10:50:28 2020] 127.0.0.1:55600 [200]: /ocs/v2.php/cloud/users/user-not-in-group
    And user "user-not-in-group" with displayname "specific-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Tue Aug 11 10:50:29 2020] 127.0.0.1:55646 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Tue Aug 11 10:50:29 2020] 127.0.0.1:55664 [200]: /ocs/v2.php/cloud/users
[Tue Aug 11 10:50:30 2020] 127.0.0.1:55730 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Tue Aug 11 10:50:30 2020] 127.0.0.1:55760 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
    And user "user-not-in-group2" with displayname "another-name" exists                          # FeatureContext::assureUserWithDisplaynameExists()
[Tue Aug 11 10:50:30 2020] 127.0.0.1:55780 [404]: /ocs/v2.php/cloud/groups/group-search
[Tue Aug 11 10:50:30 2020] 127.0.0.1:55798 [200]: /ocs/v2.php/cloud/groups
[Tue Aug 11 10:50:30 2020] 127.0.0.1:55848 [200]: /ocs/v2.php/cloud/groups/group-search
    And group "group-search" exists                                                               # FeatureContext::assureGroupExists()
[Tue Aug 11 10:50:31 2020] 127.0.0.1:55912 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Tue Aug 11 10:50:31 2020] 127.0.0.1:55954 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
[Tue Aug 11 10:50:31 2020] 127.0.0.1:55992 [200]: /ocs/v2.php/cloud/users/user-in-group/groups
    And user "user-in-group" belongs to group "group-search"                                      # FeatureContext::assureUserBelongsToGroup()
[Tue Aug 11 10:50:31 2020] 127.0.0.1:56030 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Tue Aug 11 10:50:32 2020] 127.0.0.1:56048 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
[Tue Aug 11 10:50:32 2020] 127.0.0.1:56098 [200]: /ocs/v2.php/cloud/users/user-in-group2/groups
    And user "user-in-group2" belongs to group "group-search"                                     # FeatureContext::assureUserBelongsToGroup()
[Tue Aug 11 10:50:32 2020] 127.0.0.1:56126 [200]: /ocs/v2.php/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi
    When sending "GET" to "/cloud/groups/group-search/users/details?offset=0&limit=25&search=ifi" # FeatureContext::sendingTo()
    Then the OCS status code should be "200"                                                      # FeatureContext::theOCSStatusCodeShouldBe()
    And the HTTP status code should be "200"                                                      # FeatureContext::theHTTPStatusCodeShouldBe()
    And detailed users returned are                                                               # FeatureContext::theDetailedUsersShouldBe()
      | user-in-group |
      Failed asserting that two arrays are equal.
      --- Expected
      +++ Actual
      @@ @@
       Array (
      -    0 => 'user-in-group'
[Tue Aug 11 10:50:33 2020] 127.0.0.1:56152 [200]: /ocs/v2.php/cloud/users/user-in-group
[Tue Aug 11 10:50:33 2020] 127.0.0.1:56188 [404]: /ocs/v2.php/cloud/users/user-in-group
[Tue Aug 11 10:50:33 2020] 127.0.0.1:56228 [200]: /ocs/v2.php/cloud/users/user-in-group2
[Tue Aug 11 10:50:34 2020] 127.0.0.1:56322 [404]: /ocs/v2.php/cloud/users/user-in-group2
[Tue Aug 11 10:50:34 2020] 127.0.0.1:56358 [200]: /ocs/v2.php/cloud/users/user-not-in-group
[Tue Aug 11 10:50:34 2020] 127.0.0.1:56464 [404]: /ocs/v2.php/cloud/users/user-not-in-group
[Tue Aug 11 10:50:35 2020] 127.0.0.1:56496 [200]: /ocs/v2.php/cloud/users/user-not-in-group2
[Tue Aug 11 10:50:35 2020] 127.0.0.1:56584 [404]: /ocs/v2.php/cloud/users/user-not-in-group2
[Tue Aug 11 10:50:35 2020] 127.0.0.1:56634 [200]: /ocs/v2.php/cloud/groups/group-search
[Tue Aug 11 10:50:35 2020] 127.0.0.1:56680 [404]: /ocs/v2.php/cloud/groups/group-search
[Tue Aug 11 10:50:35 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Aug 11 10:50:35 2020] 127.0.0.1:56706 [401]: /remote.php/webdav/myFileToComment.txt
[Tue Aug 11 10:50:36 2020] 127.0.0.1:56714 [207]: /remote.php/dav/systemtags/
[Tue Aug 11 10:50:36 2020] Login failed: 'user0' (Remote IP: '127.0.0.1')
[Tue Aug 11 10:50:36 2020] 127.0.0.1:56780 [401]: /remote.php/webdav/myFileToTag.txt
[Tue Aug 11 10:50:36 2020] 127.0.0.1:56786 [404]: /remote.php/dav/addressbooks/users/admin/MyAddressbook
[Tue Aug 11 10:50:36 2020] 127.0.0.1:56826 [404]: /remote.php/dav/calendars/admin/MyCalendar

@rullzer rullzer merged commit 1d123c0 into stable19 Aug 13, 2020
@rullzer rullzer deleted the backport/21775/stable19 branch August 13, 2020 03:21
@rullzer rullzer mentioned this pull request Aug 13, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@icewind1991 icewind1991 Awaiting requested review from icewind1991

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 19.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@rullzer @MorrisJobke @juliusknorr