-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pimp Oauth2 table #22502
Merged
Merged
Pimp Oauth2 table #22502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
added
3. to review
Waiting for reviews
papercut
Annoying recurring issue with possibly simple fix.
labels
Aug 30, 2020
rullzer
requested review from
georgehrke,
ChristophWurst,
juliusknorr and
skjnldsv
August 30, 2020 18:04
juliusknorr
force-pushed
the
fix/12302/oauth2_table
branch
from
August 31, 2020 05:46
5450d7f
to
1b56ae5
Compare
Fixes #12302 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
juliusknorr
force-pushed
the
fix/12302/oauth2_table
branch
from
August 31, 2020 05:48
1b56ae5
to
5659e69
Compare
juliusknorr
approved these changes
Aug 31, 2020
</th> | ||
<th id="headerSecret" scope="col"> | ||
{{ t('oauth2', 'Secret') }} | ||
<th id="headerContent"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the id is not used, so we can drop that
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 32450: failuremariadb10.1-php7.2Show full log
mysql8.0-php7.2
mysql5.6-php7.2Show full log
|
ChristophWurst
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12302
Before:
After: