Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pimp Oauth2 table #22502

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Pimp Oauth2 table #22502

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/oauth2/js/oauth2.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion apps/oauth2/js/oauth2.js.map
View file
Open in desktop

Large diffs are not rendered by default.

18 changes: 7 additions & 11 deletions apps/oauth2/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,17 +28,8 @@
<table v-if="clients.length > 0" class="grid">
<thead>
<tr>
<th id="headerName" scope="col">
{{ t('oauth2', 'Name') }}
</th>
<th id="headerRedirectUri" scope="col">
{{ t('oauth2', 'Redirection URI') }}
</th>
<th id="headerClientIdentifier" scope="col">
{{ t('oauth2', 'Client Identifier') }}
</th>
<th id="headerSecret" scope="col">
{{ t('oauth2', 'Secret') }}
<th id="headerContent">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the id is not used, so we can drop that


</th>
<th id="headerRemove">
&nbsp;
Expand Down Expand Up @@ -127,3 +118,8 @@ export default {
},
}
</script>
<style scoped>
table {
max-width: 800px;
}
</style>
29 changes: 24 additions & 5 deletions apps/oauth2/src/components/OAuthItem.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,26 @@
-->
<template>
<tr>
<td>{{ name }}</td>
<td>{{ redirectUri }}</td>
<td><code>{{ clientId }}</code></td>
<td><code>{{ renderedSecret }}</code><a class="icon-toggle has-tooltip" :title="t('oauth2', 'Show client secret')" @click="toggleSecret" /></td>
<td>
<table class="inline">
<tr>
<td>{{ t('oauth2', 'Name') }}</td>
<td>{{ name }}</td>
</tr>
<tr>
<td>{{ t('oauth2', 'Redirection URI') }}</td>
<td>{{ redirectUri }}</td>
</tr>
<tr>
<td>{{ t('oauth2', 'Client Identifier') }}</td>
<td><code>{{ clientId }}</code></td>
</tr>
<tr>
<td>{{ t('oauth2', 'Secret') }}</td>
<td><code>{{ renderedSecret }}</code><a class="icon-toggle has-tooltip" :title="t('oauth2', 'Show client secret')" @click="toggleSecret" /></td>
</tr>
</table>
</td>
<td class="action-column">
<span><a class="icon-delete has-tooltip" :title="t('oauth2', 'Delete')" @click="$emit('delete', id)" /></span>
</td>
Expand Down Expand Up @@ -79,6 +95,9 @@ export default {
td code {
display: inline-block;
vertical-align: middle;
padding: 3px;
}
table.inline td {
border: none;
padding: 5px;
}
</style>