-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[stable22] Fix svg icons disapearing in app navigation when text overflows #27957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backportbot-nextcloud
bot
requested review from
artonge,
CarlSchwan,
julien-nc,
jancborchardt,
nimishavijay and
szaimen
July 13, 2021 22:54
szaimen
approved these changes
Jul 13, 2021
MichaIng
approved these changes
Jul 13, 2021
szaimen
added
the
4. to release
Ready to be released and/or waiting for tests to finish
label
Jul 14, 2021
I'm not sure if the failing test is related to my change... |
Nearly ruled out as all tests succeeded on all other branches:
This test fails quite often randomly. But I cannot merge unless everything succeeded, and its good when someone with more insights has a look, or retriggers the drone checks. |
The issue is caused by the icon being positionned with negative margins and the `overflow: hidden` rule when hide the icon when the text overflows. Remove positioning with negative margins. This was only happening in Firefox. This fix #23849 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
backport/27936/stable22
branch
from
July 14, 2021 10:57
e8259bf
to
6505312
Compare
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #27936