Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable22] Fix svg icons disapearing in app navigation when text overflows #27957

Merged
merged 1 commit into from
Jul 14, 2021

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #27936

@szaimen szaimen added the 4. to release Ready to be released and/or waiting for tests to finish label Jul 14, 2021
@CarlSchwan
Copy link
Member

I'm not sure if the failing test is related to my change...

@MichaIng
Copy link
Member

MichaIng commented Jul 14, 2021

Nearly ruled out as all tests succeeded on all other branches:

  Scenario: open a subfolder in a public shared folder                # /drone/src/tests/acceptance/features/app-files-sharing-link.feature:40
    Given I act as John                                               # ActorContext::iActAs()
    And I am logged in                                                # LoginPageContext::iAmLoggedIn()
    And I create a new folder named "Shared folder with subfolders"   # FileListContext::iCreateANewFolderNamed()
      │ Create menu button in file list could not be clicked
      │ Exception message: element not interactable
      │   (Session info: chrome=90.0.4430.85)
      │   (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 4.15.0-137-generic x86_64)
      │ Trying again
      │ 
    And I enter in the folder named "Shared folder with subfolders"   # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                       # FileListContext::iCreateANewFolderNamed()
      │ Create New folder menu item in file list could not be clicked
      │ Exception message: element not interactable
      │   (Session info: chrome=90.0.4430.85)
      │   (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 4.15.0-137-generic x86_64)
      │ Trying again
      │ 
      element not interactable
        (Session info: chrome=90.0.4430.85)
        (Driver info: chromedriver=90.0.4430.24 (4c6d850f087da467d926e8eddb76550aed655991-refs/branch-heads/4430@{#429}),platform=Linux 4.15.0-137-generic x86_64) (WebDriver\Exception\ElementNotVisible)
    And I enter in the folder named "Subfolder"                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subsubfolder"                    # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subsubfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I open the Files app                                          # FilesAppContext::iOpenTheFilesApp()
    And I share the link for "Shared folder with subfolders"          # FilesAppSharingContext::iShareTheLinkFor()
    And I write down the shared link                                  # FilesAppSharingContext::iWriteDownTheSharedLink()
    When I act as Jane                                                # ActorContext::iActAs()
    And I visit the shared link I wrote down                          # PublicShareContext::iVisitTheSharedLinkIWroteDown()
    And I see that the current page is the shared link I wrote down   # PublicShareContext::iSeeThatTheCurrentPageIsTheSharedLinkIWroteDown()
    Then I see that the file list contains a file named "Subfolder"   # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I enter in the folder named "Subfolder"                       # FileListContext::iEnterInTheFolderNamed()
    And I see that the file list contains a file named "Subsubfolder" # FileListContext::iSeeThatTheFileListContainsAFileNamed()

This test fails quite often randomly.

But I cannot merge unless everything succeeded, and its good when someone with more insights has a look, or retriggers the drone checks.

The issue is caused by the icon being positionned with negative margins
and the `overflow: hidden` rule when hide the icon when the text
overflows. Remove positioning with negative margins. This was only
happening in Firefox.

This fix #23849

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the backport/27936/stable22 branch from e8259bf to 6505312 Compare July 14, 2021 10:57
@MichaIng MichaIng merged commit a5fa6c9 into stable22 Jul 14, 2021
@MichaIng MichaIng deleted the backport/27936/stable22 branch July 14, 2021 12:33
@skjnldsv skjnldsv mentioned this pull request Jul 26, 2021
@skjnldsv skjnldsv mentioned this pull request Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: settings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants