ensure that user and group IDs in LDAP's tables are also max 64chars #28876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blizzz
requested review from
nickvergessen,
ChristophWurst,
a team,
ArtificialOwl,
skjnldsv and
CarlSchwan
and removed request for
a team
blizzz
force-pushed
the
fix/28653/ldap-long-user-group-ids
branch
from
54c96a8 to
2d13764
Compare
blizzz
force-pushed
the
fix/28653/ldap-long-user-group-ids
branch
from
2d13764 to
fdbaef6
Compare
blizzz
force-pushed
the
fix/28653/ldap-long-user-group-ids
branch
from
fdbaef6 to
e0e41af
Compare
|
Psalm should also be happy now |
blizzz
force-pushed
the
fix/28653/ldap-long-user-group-ids
branch
from
e0e41af to
7073513
Compare
- limitation by core tables (e.g. sharing), IDs are always 64chars - when longer group IDs were requested they are hashed (does not affect displaynames) Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
force-pushed
the
fix/28653/ldap-long-user-group-ids
branch
from
7073513 to
6ab30a6
Compare
blizzz
added
4. to release
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
|
The backport to stable20 failed. Please do this backport manually. |
This was referenced Sep 27, 2021
|
stable20: #28971 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28653
While the LDAP tables were always this long, these never seemed to have happened after a first report. So it's an edge case, the migration steps should run fairly quickly in any cases. On my test instance with >34k entries in the user mappings table (but only few long ones to check – pretty much as in reality) it finished almost immediately (pgsql).