[stable22] ensure that user and group IDs in LDAP's tables are also max 64chars #28968
Conversation
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
backportbot-nextcloud
bot
requested review from
ArtificialOwl,
blizzz,
CarlSchwan,
ChristophWurst,
nickvergessen,
PVince81 and
skjnldsv
blizzz
force-pushed
the
backport/28876/stable22
branch
from
28b98ca to
7902520
Compare
| $u->setParameter('uuid', $row['directory_uuid']); | ||
| $u->setParameter('newId', $newId); | ||
| try { | ||
| $u->executeStatement(); |
There was a problem hiding this comment.
I assume the cursor will operate on the old result set and won't lock the pending updates, hope this works with all DBMS ?
There was a problem hiding this comment.
why should it not? separate queries, separate cursors.
|
this looks scary, will this mess up any mappings ? is "owncloud_name" the same as user id ? for example if we have a user in a channel in Talk by the old user id, will that user still be recognized properly after the migration ? |
yes, the And yes, the user id was shortened, but since it was too long, Nextcloud would not have been operational for users with too long user ids, i.e. login would trigger a 500, direct sharing would equally fail. Shortening the values is necessary for shrinking the column. It is a rare corner case. |
- limitation by core tables (e.g. sharing), IDs are always 64chars - when longer group IDs were requested they are hashed (does not affect displaynames) Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
PVince81
force-pushed
the
backport/28876/stable22
branch
from
7902520 to
8586d60
Compare
|
I've solved the conflict on the version number |
⚠️ This backport had conflicts and is incomplete ⚠️ backport of #28876